SADM/pest
1
0
Fork 0
mirror of https://github.com/pestphp/pest.git synced 2026-03-13 03:07:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

refacto: early returns

Browse Source
This commit is contained in:
Nuno Maduro
2023-06-15 10:38:17 +02:00
parent 7460bd6c1f
commit 5959890125
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Result.php
View File

@ -39,15 +39,13 @@ final class Result
*/ */
public static function exitCode(Configuration $configuration, TestResult $result): int public static function exitCode(Configuration $configuration, TestResult $result): int
{ {
$returnCode = self::FAILURE_EXIT;
if ($result->wasSuccessfulIgnoringPhpunitWarnings() if ($result->wasSuccessfulIgnoringPhpunitWarnings()
&& ! $result->hasTestTriggeredPhpunitWarningEvents()) { && ! $result->hasTestTriggeredPhpunitWarningEvents()) {
$returnCode = self::SUCCESS_EXIT; return self::SUCCESS_EXIT;
} }
if ($configuration->failOnEmptyTestSuite() && $result->numberOfTests() === 0) { if ($configuration->failOnEmptyTestSuite() && $result->numberOfTests() === 0) {
$returnCode = self::FAILURE_EXIT; return self::FAILURE_EXIT;
} }
if ($result->wasSuccessfulIgnoringPhpunitWarnings()) { if ($result->wasSuccessfulIgnoringPhpunitWarnings()) {
@ -76,6 +74,6 @@ final class Result
return self::EXCEPTION_EXIT; return self::EXCEPTION_EXIT;
} }
return $returnCode; return self::FAILURE_EXIT;
} }
} }