refacto: early returns

This commit is contained in:
Nuno Maduro
2023-06-15 10:38:17 +02:00
parent 7460bd6c1f
commit 5959890125

View File

@ -39,15 +39,13 @@ final class Result
*/
public static function exitCode(Configuration $configuration, TestResult $result): int
{
$returnCode = self::FAILURE_EXIT;
if ($result->wasSuccessfulIgnoringPhpunitWarnings()
&& ! $result->hasTestTriggeredPhpunitWarningEvents()) {
$returnCode = self::SUCCESS_EXIT;
return self::SUCCESS_EXIT;
}
if ($configuration->failOnEmptyTestSuite() && $result->numberOfTests() === 0) {
$returnCode = self::FAILURE_EXIT;
return self::FAILURE_EXIT;
}
if ($result->wasSuccessfulIgnoringPhpunitWarnings()) {
@ -76,6 +74,6 @@ final class Result
return self::EXCEPTION_EXIT;
}
return $returnCode;
return self::FAILURE_EXIT;
}
}