From 595989012571826c05219d583c263a443dc526c7 Mon Sep 17 00:00:00 2001 From: Nuno Maduro Date: Thu, 15 Jun 2023 10:38:17 +0200 Subject: [PATCH] refacto: early returns --- src/Result.php | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/Result.php b/src/Result.php index 9f0b6382..418de7db 100644 --- a/src/Result.php +++ b/src/Result.php @@ -39,15 +39,13 @@ final class Result */ public static function exitCode(Configuration $configuration, TestResult $result): int { - $returnCode = self::FAILURE_EXIT; - if ($result->wasSuccessfulIgnoringPhpunitWarnings() && ! $result->hasTestTriggeredPhpunitWarningEvents()) { - $returnCode = self::SUCCESS_EXIT; + return self::SUCCESS_EXIT; } if ($configuration->failOnEmptyTestSuite() && $result->numberOfTests() === 0) { - $returnCode = self::FAILURE_EXIT; + return self::FAILURE_EXIT; } if ($result->wasSuccessfulIgnoringPhpunitWarnings()) { @@ -76,6 +74,6 @@ final class Result return self::EXCEPTION_EXIT; } - return $returnCode; + return self::FAILURE_EXIT; } }