Compare commits

..

21 Commits

Author SHA1 Message Date
5bbdd4f41e docs: updates changelog 2020-11-23 21:43:58 +01:00
3fd24d96d3 feat: casts to array using toArray 2020-11-23 21:37:35 +01:00
7bea51fe09 feat: adds toMatchArray 2020-11-23 21:26:02 +01:00
cdf0a38145 Merge pull request #216 from owenvoke/bugfix/depends
fix(depends): resolve issue with dependency names
2020-11-23 08:43:58 +00:00
bb2474ccbe tests: add regression tests for depends 2020-11-13 11:14:17 +00:00
01143a6f84 fix(depends): resolve issue with dependency names 2020-11-13 11:08:35 +00:00
b93485c2ed Merge pull request #217 from owenvoke/feature/help
feat: add Pest options to help output
2020-11-12 14:59:50 +00:00
04681690b6 tests: update help snapshot to only include Pest options 2020-11-12 09:53:40 +00:00
200877d691 tests: update to use snapshot for help output 2020-11-12 09:44:26 +00:00
feb6417f45 tests: add visual test for help output 2020-11-12 09:11:51 +00:00
e7585a4ba2 tests: update snapshots 2020-11-12 09:03:44 +00:00
c33ab0f670 tests: add test for help output 2020-11-12 09:03:44 +00:00
78181f66f6 feat: add Pest options to help output 2020-11-12 09:03:43 +00:00
925636be61 docs: add missing bracket 2020-11-11 23:31:19 +00:00
6be131d602 chore: update changelog 2020-11-11 23:29:18 +00:00
f950f57eed Merge pull request #219 from owenvoke/feature/phpunit
chore(deps): add support for PHPUnit 9.4.3
2020-11-11 22:35:26 +00:00
c6369feaea chore(deps): add support for PHPUnit 9.4.3 2020-11-11 22:26:53 +00:00
1bdd3f4908 Update Pest.php 2020-11-09 10:56:14 +01:00
924e095dfc chore: updates changelog 2020-11-09 10:55:22 +01:00
72041a4a21 Merge pull request #215 from olivernybroe/teamcity-exception
Improve exception output in teamcity printer
2020-11-09 10:52:08 +01:00
d576446639 Improve exception output in teamcity printer 2020-11-04 09:17:57 +01:00
14 changed files with 179 additions and 34 deletions

View File

@ -4,7 +4,17 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).
## [Unreleased]
## [v0.3.13 (2020-11-23)](https://github.com/pestphp/pest/compare/v0.3.12...v0.3.13)
### Added
- `toMatchArray` expectation ([7bea51f](https://github.com/pestphp/pest/commit/7bea51fe09dd2eca7093e4c34cf2dab2e8d39fa5), [3fd24d9](https://github.com/pestphp/pest/commit/3fd24d96d3145dcebdb0aab40aa8b76faa8b6979))
## [v0.3.12 (2020-11-11)](https://github.com/pestphp/pest/compare/v0.3.11...v0.3.12)
### Added
- Add support for PHPUnit 9.4.3 ([#219](https://github.com/pestphp/pest/pull/219))
## [v0.3.11 (2020-11-09)](https://github.com/pestphp/pest/compare/v0.3.10...v0.3.11)
### Changed
- Improved the exception output for the TeamCity printer (usage with phpstorm plugin) ([#215](https://github.com/pestphp/pest/pull/215))
## [v0.3.10 (2020-11-01)](https://github.com/pestphp/pest/compare/v0.3.9...v0.3.10)
### Added

View File

@ -22,7 +22,7 @@
"pestphp/pest-plugin": "^0.3",
"pestphp/pest-plugin-coverage": "^0.3",
"pestphp/pest-plugin-init": "^0.3",
"phpunit/phpunit": ">= 9.3.7 <= 9.4.2"
"phpunit/phpunit": ">= 9.3.7 <= 9.4.3"
},
"autoload": {
"psr-4": {

View File

@ -148,5 +148,7 @@ final class Command extends BaseCommand
$version = Container::getInstance()->get(Version::class);
$version->handleArguments(['--version']);
parent::showHelp();
(new Help($this->output))();
}
}

37
src/Console/Help.php Normal file
View File

@ -0,0 +1,37 @@
<?php
declare(strict_types=1);
namespace Pest\Console;
use Symfony\Component\Console\Output\OutputInterface;
/**
* @internal
*/
final class Help
{
/** @var array<int, string> */
private const HELP_MESSAGES = [
'<comment>Pest Options:</comment>',
' <info>--init</info> Initialise a standard Pest configuration',
' <info>--coverage</info> Enable coverage and output to standard output',
' <info>--min=<fg=cyan><N></></info> Set the minimum required coverage percentage (<N>), and fail if not met',
' <info>--group=<fg=cyan><name></></info> Only runs tests from the specified group(s)',
];
/** @var OutputInterface */
private $output;
public function __construct(OutputInterface $output)
{
$this->output = $output;
}
public function __invoke(): void
{
foreach (self::HELP_MESSAGES as $message) {
$this->output->writeln($message);
}
}
}

View File

@ -408,10 +408,21 @@ final class Expectation
* Asserts that the value array has the provided $key.
*
* @param string|int $key
* @param mixed $value
*/
public function toHaveKey($key): Expectation
public function toHaveKey($key, $value = null): Expectation
{
Assert::assertArrayHasKey($key, $this->value);
if (is_object($this->value) && method_exists($this->value, 'toArray')) {
$array = $this->value->toArray();
} else {
$array = (array) $this->value;
}
Assert::assertArrayHasKey($key, $array);
if (func_num_args() > 1) {
Assert::assertEquals($value, $array[$key]);
}
return $this;
}
@ -490,6 +501,20 @@ final class Expectation
return $this;
}
/**
* Asserts that the value array matches the given array subset.
*
* @param array<int|string, mixed> $array
*/
public function toMatchArray($array): Expectation
{
foreach ($array as $property => $value) {
$this->toHaveKey($property, $value);
}
return $this;
}
/**
* Asserts that the value object matches a subset
* of the properties of an given object.

View File

@ -95,7 +95,11 @@ final class TestCall
$className = $this->testCaseFactory->getClassName();
$tests = array_map(function (string $test) use ($className): ExecutionOrderDependency {
return ExecutionOrderDependency::createFromDependsAnnotation($className, $test);
if (strpos($test, '::') === false) {
$test = "{$className}::{$test}";
}
return new ExecutionOrderDependency($test, null, '');
}, $tests);
$this->testCaseFactory

View File

@ -6,5 +6,5 @@ namespace Pest;
function version(): string
{
return '0.3.9';
return '0.3.12';
}

View File

@ -24,7 +24,6 @@ final class TeamCity extends DefaultResultPrinter
private const DURATION = 'duration';
private const TEST_SUITE_STARTED = 'testSuiteStarted';
private const TEST_SUITE_FINISHED = 'testSuiteFinished';
private const TEST_FAILED = 'testFailed';
/** @var int */
private $flowId;
@ -149,19 +148,7 @@ final class TeamCity extends DefaultResultPrinter
*/
public function addError(Test $test, Throwable $t, float $time): void
{
if (!TeamCity::isPestTest($test)) {
$this->phpunitTeamCity->addError($test, $t, $time);
return;
}
$this->printEvent(
self::TEST_FAILED, [
self::NAME => $test->getName(),
'message' => $t->getMessage(),
'details' => $t->getTraceAsString(),
self::DURATION => self::toMilliseconds($time),
]);
$this->phpunitTeamCity->addError($test, $t, $time);
}
/**
@ -171,19 +158,7 @@ final class TeamCity extends DefaultResultPrinter
*/
public function addWarning(Test $test, Warning $e, float $time): void
{
if (!TeamCity::isPestTest($test)) {
$this->phpunitTeamCity->addWarning($test, $e, $time);
return;
}
$this->printEvent(
self::TEST_FAILED, [
self::NAME => $test->getName(),
'message' => $e->getMessage(),
'details' => $e->getTraceAsString(),
self::DURATION => self::toMilliseconds($time),
]);
$this->phpunitTeamCity->addWarning($test, $e, $time);
}
public function addFailure(Test $test, AssertionFailedError $e, float $time): void

View File

@ -0,0 +1,5 @@
Pest Options:
--init Initialise a standard Pest configuration
--coverage Enable coverage and output to standard output
--min=<N> Set the minimum required coverage percentage (<N>), and fail if not met
--group=<name> Only runs tests from the specified group(s)

View File

@ -200,6 +200,11 @@
PASS Tests\Expect\toMatch
✓ pass
✓ failures
✓ not failures
PASS Tests\Expect\toMatchArray
✓ pass
✓ failures
✓ not failures
PASS Tests\Expect\toMatchConstraint
@ -348,6 +353,9 @@
✓ it throws exception when `process isolation` is true
✓ it do not throws exception when `process isolation` is false
PASS Tests\Unit\Console\Help
✓ it outputs the help information when --help is used
PASS Tests\Unit\Datasets
✓ it show the names of named datasets in their description
@ -374,6 +382,9 @@
PASS Tests\Unit\TestSuite
✓ it does not allow to add the same test description twice
PASS Tests\Visual\Help
✓ visual snapshot of help command output
PASS Tests\Visual\SingleTestOrDirectory
✓ allows to run a single test
✓ allows to run a directory
@ -386,10 +397,12 @@
PASS Tests\Features\Depends
✓ first
✓ second
✓ it asserts true is true
✓ depends
✓ depends with ...params
✓ depends with defined arguments
✓ depends run test only once
✓ depends works with the correct test name
Tests: 7 skipped, 231 passed
Tests: 7 skipped, 238 passed

View File

@ -0,0 +1,31 @@
<?php
use PHPUnit\Framework\ExpectationFailedException;
beforeEach(function () {
$this->user = [
'id' => 1,
'name' => 'Nuno',
'email' => 'enunomaduro@gmail.com',
];
});
test('pass', function () {
expect($this->user)->toMatchArray([
'name' => 'Nuno',
'email' => 'enunomaduro@gmail.com',
]);
});
test('failures', function () {
expect($this->user)->toMatchArray([
'name' => 'Not the same name',
'email' => 'enunomaduro@gmail.com',
]);
})->throws(ExpectationFailedException::class);
test('not failures', function () {
expect($this->user)->not->toMatchArray([
'id' => 1,
]);
})->throws(ExpectationFailedException::class);

View File

@ -32,3 +32,7 @@ test('depends with defined arguments', function (string $first, string $second)
test('depends run test only once', function () use (&$runCounter) {
expect($runCounter)->toBe(2);
})->depends('first', 'second');
// Regression tests. See https://github.com/pestphp/pest/pull/216
it('asserts true is true')->assertTrue(true);
test('depends works with the correct test name')->assertTrue(true)->depends('it asserts true is true');

View File

@ -0,0 +1,12 @@
<?php
use Pest\Console\Help;
use Symfony\Component\Console\Output\BufferedOutput;
it('outputs the help information when --help is used', function () {
$output = new BufferedOutput();
$plugin = new Help($output);
$plugin();
expect($output->fetch())->toContain('Pest Options:');
});

27
tests/Visual/Help.php Normal file
View File

@ -0,0 +1,27 @@
<?php
use Pest\Console\Help;
use Symfony\Component\Console\Output\BufferedOutput;
test('visual snapshot of help command output', function () {
$snapshot = __DIR__ . '/../.snapshots/help-command.txt';
if (getenv('REBUILD_SNAPSHOTS')) {
$outputBuffer = new BufferedOutput();
$plugin = new Help($outputBuffer);
$plugin();
file_put_contents($snapshot, $outputBuffer->fetch());
}
$output = function () {
$process = (new Symfony\Component\Process\Process(['php', 'bin/pest', '--help']));
$process->run();
return preg_replace('#\\x1b[[][^A-Za-z]*[A-Za-z]#', '', $process->getOutput());
};
expect($output())->toContain(file_get_contents($snapshot));
})->skip(PHP_OS_FAMILY === 'Windows');