SADM/pest
1
0
Fork 0
mirror of https://github.com/pestphp/pest.git synced 2026-03-12 10:47:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix unreachable test case from multiple datasets

Browse Source
This commit is contained in:
Fabio Ivona
2023-03-13 18:14:26 +01:00
parent dbef162fa6
commit d6e3906da6
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/Concerns/Testable.php
View File

@ -228,17 +228,16 @@ trait Testable
$this->__description = self::$__latestDescription = $this->dataName() ? $method->description.' with '.$this->dataName() : $method->description; $this->__description = self::$__latestDescription = $this->dataName() ? $method->description.' with '.$this->dataName() : $method->description;
$underlyingTest = Reflection::getFunctionVariable($this->__test, 'closure'); $underlyingTest = Reflection::getFunctionVariable($this->__test, 'closure');
$testParameterTypes = array_values(Reflection::getFunctionArguments($underlyingTest)); $testParameterTypes = array_values(Reflection::getFunctionArguments($underlyingTest));
if (count($arguments) !== 1) { if (count($arguments) !== 1) {
foreach ($arguments as $argumentIndex => $argumentValue) { foreach ($arguments as $argumentIndex => $argumentValue) {
if (!$argumentValue instanceof Closure) { if (! $argumentValue instanceof Closure) {
continue; continue;
} }
if (in_array($testParameterTypes[$argumentIndex], [\Closure::class, 'callable'])) { if (in_array($testParameterTypes[$argumentIndex], [\Closure::class, 'callable', 'mixed'])) {
continue; continue;
} }
@ -248,7 +247,7 @@ trait Testable
return $arguments; return $arguments;
} }
if (!$arguments[0] instanceof Closure) { if (! $arguments[0] instanceof Closure) {
return $arguments; return $arguments;
} }
@ -260,7 +259,7 @@ trait Testable
if (count($testParameterTypes) === 1) { if (count($testParameterTypes) === 1) {
return [$boundDatasetResult]; return [$boundDatasetResult];
} }
if (!is_array($boundDatasetResult)) { if (! is_array($boundDatasetResult)) {
return [$boundDatasetResult]; return [$boundDatasetResult];
} }