Fix unreachable test case from multiple datasets

This commit is contained in:
Fabio Ivona
2023-03-13 18:14:26 +01:00
parent dbef162fa6
commit d6e3906da6

View File

@ -228,17 +228,16 @@ trait Testable
$this->__description = self::$__latestDescription = $this->dataName() ? $method->description.' with '.$this->dataName() : $method->description;
$underlyingTest = Reflection::getFunctionVariable($this->__test, 'closure');
$testParameterTypes = array_values(Reflection::getFunctionArguments($underlyingTest));
if (count($arguments) !== 1) {
foreach ($arguments as $argumentIndex => $argumentValue) {
if (!$argumentValue instanceof Closure) {
if (! $argumentValue instanceof Closure) {
continue;
}
if (in_array($testParameterTypes[$argumentIndex], [\Closure::class, 'callable'])) {
if (in_array($testParameterTypes[$argumentIndex], [\Closure::class, 'callable', 'mixed'])) {
continue;
}
@ -248,7 +247,7 @@ trait Testable
return $arguments;
}
if (!$arguments[0] instanceof Closure) {
if (! $arguments[0] instanceof Closure) {
return $arguments;
}
@ -260,7 +259,7 @@ trait Testable
if (count($testParameterTypes) === 1) {
return [$boundDatasetResult];
}
if (!is_array($boundDatasetResult)) {
if (! is_array($boundDatasetResult)) {
return [$boundDatasetResult];
}