Merge pull request #923 from hungthai1401/inconsistent_type_have_count_exception

[2.x] Inconsistent type have count exception
This commit is contained in:
Nuno Maduro
2023-08-22 10:37:59 +01:00
committed by GitHub
2 changed files with 6 additions and 1 deletions

View File

@ -264,7 +264,7 @@ final class Expectation
public function toHaveCount(int $count, string $message = ''): self
{
if (! is_countable($this->value) && ! is_iterable($this->value)) {
InvalidExpectationValue::expected('string');
InvalidExpectationValue::expected('countable|iterable');
}
Assert::assertCount($count, $this->value, $message);

View File

@ -1,11 +1,16 @@
<?php
use Pest\Exceptions\InvalidExpectationValue;
use PHPUnit\Framework\ExpectationFailedException;
test('pass', function () {
expect([1, 2, 3])->toHaveCount(3);
});
test('failures with invalid type', function () {
expect('foo')->toHaveCount(3);
})->throws(InvalidExpectationValue::class, 'Invalid expectation value type. Expected [countable|iterable]');
test('failures', function () {
expect([1, 2, 3])->toHaveCount(4);
})->throws(ExpectationFailedException::class);