unify converter

src/Logging/Converter.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Pest\Logging\TeamCity;
+namespace Pest\Logging;
 
 use NunoMaduro\Collision\Adapters\Phpunit\State;
 use Pest\Exceptions\ShouldNotHappen;
@@ -150,6 +150,14 @@ final class Converter
         return Str::after($name, self::PREFIX);
     }
 
+    /**
+     * Gets the trimmed test class name.
+     */
+    public function getTrimmedTestClassName(TestMethod $test): string
+    {
+        return Str::after($test->className(), self::PREFIX);
+    }
+
     /**
      * Gets the test suite location.
      */

src/Logging/JUnit/Converter.php

@@ -1,183 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Pest\Logging\JUnit;
-
-use Pest\Exceptions\ShouldNotHappen;
-use Pest\Support\Str;
-use PHPUnit\Event\Code\Test;
-use PHPUnit\Event\Code\TestMethod;
-use PHPUnit\Event\Code\Throwable;
-use PHPUnit\Event\TestSuite\TestSuite;
-use PHPUnit\Framework\Exception as FrameworkException;
-
-/**
- * @internal
- */
-final class Converter
-{
-    private const PREFIX = 'P\\';
-
-    /**
-     * Creates a new instance of the Converter.
-     */
-    public function __construct(
-        private readonly string $rootPath,
-    ) {
-    }
-
-    /**
-     * Gets the test case method name.
-     */
-    public function getTestCaseMethodName(Test $test): string
-    {
-        if (! $test instanceof TestMethod) {
-            throw ShouldNotHappen::fromMessage('Not an instance of TestMethod');
-        }
-
-        return $test->testDox()->prettifiedMethodName();
-    }
-
-    /**
-     * Gets the test case location.
-     */
-    public function getTestCaseLocation(Test $test, bool $withDescription = false): string
-    {
-        if (! $test instanceof TestMethod) {
-            throw ShouldNotHappen::fromMessage('Not an instance of TestMethod');
-        }
-
-        $path = $test->testDox()->prettifiedClassName();
-        $relativePath = $this->toRelativePath($path);
-
-        // TODO: Get the description without the dataset.
-        $description = $test->testDox()->prettifiedMethodName();
-
-        if (! $withDescription) {
-            return $relativePath;
-        }
-
-        return "$relativePath::$description";
-    }
-
-    /**
-     * Gets the trimmed test class name.
-     */
-    public function getTrimmedTestClassName(TestMethod $test): string
-    {
-        return Str::after($test->className(), self::PREFIX);
-    }
-
-    /**
-     * Gets the exception message.
-     */
-    public function getExceptionMessage(Throwable $throwable): string
-    {
-        if (is_a($throwable->className(), FrameworkException::class, true)) {
-            return $throwable->message();
-        }
-
-        $buffer = $throwable->className();
-        $throwableMessage = $throwable->message();
-
-        if ($throwableMessage !== '') {
-            $buffer .= ": $throwableMessage";
-        }
-
-        return $buffer;
-    }
-
-    /**
-     * Gets the exception details.
-     */
-    public function getExceptionDetails(Throwable $throwable): string
-    {
-        $buffer = $this->getStackTrace($throwable);
-
-        while ($throwable->hasPrevious()) {
-            $throwable = $throwable->previous();
-
-            $buffer .= sprintf(
-                "\nCaused by\n%s\n%s",
-                $throwable->description(),
-                $this->getStackTrace($throwable)
-            );
-        }
-
-        return $buffer;
-    }
-
-    /**
-     * Gets the stack trace.
-     */
-    public function getStackTrace(Throwable $throwable): string
-    {
-        $stackTrace = $throwable->stackTrace();
-
-        // Split stacktrace per frame.
-        $frames = explode("\n", $stackTrace);
-
-        // Remove empty lines
-        $frames = array_filter($frames);
-
-        // clean the paths of each frame.
-        $frames = array_map(
-            fn (string $frame): string => $this->toRelativePath($frame),
-            $frames
-        );
-
-        // Format stacktrace as `at <path>`
-        $frames = array_map(
-            fn (string $frame) => "at $frame",
-            $frames
-        );
-
-        return implode("\n", $frames);
-    }
-
-    /**
-     * Gets the test suite name.
-     */
-    public function getTestSuiteName(TestSuite $testSuite): string
-    {
-        $name = $testSuite->name();
-
-        if (str_starts_with($name, self::PREFIX)) {
-            return Str::after($name, self::PREFIX);
-        }
-
-        return Str::after($name, $this->rootPath);
-    }
-
-    /**
-     * Gets the test suite location.
-     */
-    public function getTestSuiteLocation(TestSuite $testSuite): ?string
-    {
-        $tests = $testSuite->tests()->asArray();
-
-        // TODO: figure out how to get the file path without a test being there.
-        if ($tests === []) {
-            return null;
-        }
-
-        $firstTest = $tests[0];
-        if (! $firstTest instanceof TestMethod) {
-            throw ShouldNotHappen::fromMessage('Not an instance of TestMethod');
-        }
-
-        $path = $firstTest->testDox()->prettifiedClassName();
-
-        return $this->toRelativePath($path);
-    }
-
-    /**
-     * Transforms the given path in relative path.
-     */
-    private function toRelativePath(string $path): string
-    {
-        // Remove cwd from the path.
-        return str_replace("$this->rootPath".DIRECTORY_SEPARATOR, '', $path);
-    }
-}

src/Logging/JUnit/JUnitLogger.php

@@ -6,6 +6,7 @@ namespace Pest\Logging\JUnit;
 
 use DOMDocument;
 use DOMElement;
+use Pest\Logging\Converter;
 use Pest\Logging\JUnit\Subscriber\TestErroredSubscriber;
 use Pest\Logging\JUnit\Subscriber\TestFailedSubscriber;
 use Pest\Logging\JUnit\Subscriber\TestFinishedSubscriber;

src/Logging/TeamCity/TeamCityLogger.php

@@ -6,6 +6,7 @@ namespace Pest\Logging\TeamCity;
 
 use NunoMaduro\Collision\Adapters\Phpunit\Style;
 use Pest\Exceptions\ShouldNotHappen;
+use Pest\Logging\Converter;
 use Pest\Logging\TeamCity\Subscriber\TestConsideredRiskySubscriber;
 use Pest\Logging\TeamCity\Subscriber\TestErroredSubscriber;
 use Pest\Logging\TeamCity\Subscriber\TestExecutionFinishedSubscriber;

src/Subscribers/EnsureJunitEnabled.php

@@ -4,8 +4,8 @@ declare(strict_types=1);
 
 namespace Pest\Subscribers;
 
+use Pest\Logging\Converter;
 use Pest\Logging\JUnit\JUnitLogger;
-use Pest\Logging\JUnit\Converter;
 use Pest\Support\Container;
 use Pest\TestSuite;
 use PHPUnit\Event\TestRunner\Configured;

src/Subscribers/EnsureTeamCityEnabled.php

@@ -4,7 +4,7 @@ declare(strict_types=1);
 
 namespace Pest\Subscribers;
 
-use Pest\Logging\TeamCity\Converter;
+use Pest\Logging\Converter;
 use Pest\Logging\TeamCity\TeamCityLogger;
 use Pest\TestSuite;
 use PHPUnit\Event\TestRunner\Configured;