release: 2.36.1

.github/workflows/static.yml

@@ -1,44 +0,0 @@
-name: Static Analysis
-
-on:
-  push:
-  pull_request:
-  schedule:
-    - cron: '0 0 * * *'
-
-jobs:
-  static:
-    if: github.event_name != 'schedule' || github.repository == 'pestphp/pest'
-    name: Static Tests
-
-    runs-on: ubuntu-latest
-    strategy:
-      fail-fast: true
-      matrix:
-        dependency-version: [prefer-lowest, prefer-stable]
-
-    steps:
-    - name: Checkout
-      uses: actions/checkout@v4
-
-    - name: Setup PHP
-      uses: shivammathur/setup-php@v2
-      with:
-        php-version: 8.1
-        tools: composer:v2
-        coverage: none
-
-    - name: Install Dependencies
-      run: composer update --prefer-stable --no-interaction --no-progress --ansi
-
-    - name: Type Check
-      run: composer test:type:check
-
-    - name: Type Coverage
-      run: composer test:type:coverage
-
-    - name: Refacto
-      run: composer test:refacto
-
-    - name: Style
-      run: composer test:lint

.github/workflows/tests.yml

@@ -14,11 +14,8 @@ jobs:
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
         symfony: ['6.4', '7.0']
-        php: ['8.1', '8.2', '8.3']
+        php: ['8.2', '8.3', '8.4']
-        dependency_version: [prefer-lowest, prefer-stable]
+        dependency_version: [prefer-stable]
-        exclude:
-          - php: '8.1'
-            symfony: '7.0'
 
     name: PHP ${{ matrix.php }} - Symfony ^${{ matrix.symfony }} - ${{ matrix.os }} - ${{ matrix.dependency_version }}
 

composer.json

@@ -17,16 +17,17 @@
         }
     ],
     "require": {
-        "php": "^8.1.0",
+        "php": "^8.2.0",
-        "brianium/paratest": "^7.3.1",
+        "brianium/paratest": "^7.4.9",
-        "nunomaduro/collision": "^7.10.0|^8.4.0",
+        "nunomaduro/collision": "^7.11.0|^8.5.0",
-        "nunomaduro/termwind": "^1.15.1|^2.0.1",
+        "nunomaduro/termwind": "^1.16.0|^2.3.3",
         "pestphp/pest-plugin": "^2.1.1",
         "pestphp/pest-plugin-arch": "^2.7.0",
-        "phpunit/phpunit": "^10.5.17"
+        "phpunit/phpunit": "^10.5.63"
     },
     "conflict": {
-        "phpunit/phpunit": ">10.5.17",
+        "filp/whoops": "<2.16.0",
+        "phpunit/phpunit": ">10.5.63",
         "sebastian/exporter": "<5.1.0",
         "webmozart/assert": "<1.11.0"
     },
@@ -51,9 +52,9 @@
         ]
     },
     "require-dev": {
-        "pestphp/pest-dev-tools": "^2.16.0",
+        "pestphp/pest-dev-tools": "^2.17.0",
-        "pestphp/pest-plugin-type-coverage": "^2.8.5",
+        "pestphp/pest-plugin-type-coverage": "^2.8.7",
-        "symfony/process": "^6.4.0|^7.1.3"
+        "symfony/process": "^6.4.0|^7.4.4"
     },
     "minimum-stability": "dev",
     "prefer-stable": true,
@@ -68,22 +69,12 @@
         "bin/pest"
     ],
     "scripts": {
-        "refacto": "rector",
-        "lint": "pint",
-        "test:refacto": "rector --dry-run",
-        "test:lint": "pint --test",
-        "test:type:check": "phpstan analyse --ansi --memory-limit=-1 --debug",
-        "test:type:coverage": "php -d memory_limit=-1  bin/pest --type-coverage --min=100",
         "test:unit": "php bin/pest --colors=always --exclude-group=integration --compact",
         "test:inline": "php bin/pest --colors=always --configuration=phpunit.inline.xml",
         "test:parallel": "php bin/pest --colors=always --exclude-group=integration --parallel --processes=3",
         "test:integration": "php bin/pest --colors=always --group=integration",
         "update:snapshots": "REBUILD_SNAPSHOTS=true php bin/pest --colors=always --update-snapshots",
         "test": [
-            "@test:refacto",
-            "@test:lint",
-            "@test:type:check",
-            "@test:type:coverage",
             "@test:unit",
             "@test:parallel",
             "@test:integration"

phpstan.neon

@@ -1,6 +1,5 @@
 includes:
     - vendor/phpstan/phpstan-strict-rules/rules.neon
-    - vendor/ergebnis/phpstan-rules/rules.neon
     - vendor/thecodingmachine/phpstan-strict-rules/phpstan-strict-rules.neon
 
 parameters:
@@ -12,12 +11,4 @@ parameters:
     reportUnmatchedIgnoredErrors: true
 
     ignoreErrors:
-        - "#has a nullable return type declaration.#"
-        - "#Language construct isset\\(\\) should not be used.#"
-        - "#is not allowed to extend#"
-        - "#is concrete, but does not have a Test suffix#"
-        - "#with a nullable type declaration#"
         - "#type mixed is not subtype of native#"
-        - "# with null as default value#"
-        - "#has parameter \\$closure with default value.#"
-        - "#has parameter \\$description with default value.#"

src/Factories/Attributes/Attribute.php

@@ -20,7 +20,7 @@ abstract class Attribute
      * @param  array<int, string>  $attributes
      * @return array<int, string>
      */
-    public function __invoke(TestCaseMethodFactory $method, array $attributes): array  // @phpstan-ignore-line
+    public function __invoke(TestCaseMethodFactory $method, array $attributes): array
     {
         return $attributes;
     }

src/Factories/TestCaseFactory.php

@@ -194,7 +194,7 @@ final class TestCaseFactory
             }
             PHP;
 
-            eval($classCode); // @phpstan-ignore-line
+            eval($classCode);
         } catch (ParseError $caught) {
             throw new RuntimeException(sprintf(
                 "Unable to create test case for test file at %s. \n %s",

src/KernelDump.php

@@ -40,7 +40,7 @@ final class KernelDump
      */
     public function disable(): void
     {
-        @ob_clean(); // @phpstan-ignore-line
+        @ob_clean();
 
         if ($this->buffer !== '') {
             $this->flush();

src/Pest.php

@@ -6,7 +6,7 @@ namespace Pest;
 
 function version(): string
 {
-    return '2.35.1';
+    return '2.36.1';
 }
 
 function testDirectory(string $file = ''): string

src/Result.php

@@ -40,7 +40,7 @@ final class Result
      */
     public static function exitCode(Configuration $configuration, TestResult $result): int
     {
-        if ($result->wasSuccessfulIgnoringPhpunitWarnings()) {
+        if ($result->wasSuccessful()) {
             if ($configuration->failOnWarning()) {
                 $warnings = $result->numberOfTestsWithTestTriggeredPhpunitWarningEvents()
                     + count($result->warnings())
@@ -60,7 +60,7 @@ final class Result
             return self::FAILURE_EXIT;
         }
 
-        if ($result->wasSuccessfulIgnoringPhpunitWarnings()) {
+        if ($result->wasSuccessful()) {
             if ($configuration->failOnRisky() && $result->hasTestConsideredRiskyEvents()) {
                 $returnCode = self::FAILURE_EXIT;
             }

tests/.pest/snapshots/Visual/Help/visual_snapshot_of_help_command_output.snap

@@ -1,5 +1,5 @@
 
-  Pest Testing Framework 2.35.1.  
+  Pest Testing Framework 2.36.1.  
 
   USAGE: pest <file> [options]  
 
@@ -45,7 +45,7 @@
   --disallow-test-output ................. Be strict about output during tests  
   --enforce-time-limit ................. Enforce time limit based on test size  
   --default-time-limit [sec]  Timeout in seconds for tests that have no declared size  
-  --dont-report-useless-tests .. Do not report tests that do not test anything  
+  --do-not-report-useless-tests  Do not report tests that do not test anything  
   --stop-on-defect ... Stop after first error, failure, warning, or risky test  
   --stop-on-error ..................................... Stop after first error  
   --stop-on-failure ................................. Stop after first failure  
@@ -59,9 +59,21 @@
   --fail-on-warning  Signal failure using shell exit code when a warning was triggered  
   --fail-on-risky  Signal failure using shell exit code when a test was considered risky  
   --fail-on-deprecation  Signal failure using shell exit code when a deprecation was triggered  
+  --fail-on-phpunit-deprecation  Signal failure using shell exit code when a PHPUnit deprecation was triggered  
+  --fail-on-phpunit-warning  Signal failure using shell exit code when a PHPUnit warning was triggered  
   --fail-on-notice  Signal failure using shell exit code when a notice was triggered  
   --fail-on-skipped  Signal failure using shell exit code when a test was skipped  
   --fail-on-incomplete  Signal failure using shell exit code when a test was marked incomplete  
+  --fail-on-all-issues  Signal failure using shell exit code when an issue is triggered  
+  --do-not-fail-on-empty-test-suite  Do not signal failure using shell exit code when no tests were run  
+  --do-not-fail-on-warning  Do not signal failure using shell exit code when a warning was triggered  
+  --do-not-fail-on-risky  Do not signal failure using shell exit code when a test was considered risky  
+  --do-not-fail-on-deprecation  Do not signal failure using shell exit code when a deprecation was triggered  
+  --do-not-fail-on-phpunit-deprecation  Do not signal failure using shell exit code when a PHPUnit deprecation was triggered  
+  --do-not-fail-on-phpunit-warning  Do not signal failure using shell exit code when a PHPUnit warning was triggered  
+  --do-not-fail-on-notice  Do not signal failure using shell exit code when a notice was triggered  
+  --do-not-fail-on-skipped  Do not signal failure using shell exit code when a test was skipped  
+  --do-not-fail-on-incomplete  Do not signal failure using shell exit code when a test was marked incomplete  
   --cache-result ............................ Write test results to cache file  
   --do-not-cache-result .............. Do not write test results to cache file  
   --order-by [order]  Run tests in order: default|defects|depends|duration|no-depends|random|reverse|size  
@@ -78,9 +90,11 @@
   --display-incomplete .................. Display details for incomplete tests  
   --display-skipped ........................ Display details for skipped tests  
   --display-deprecations . Display details for deprecations triggered by tests  
+  --display-phpunit-deprecations .... Display details for PHPUnit deprecations  
   --display-errors ............. Display details for errors triggered by tests  
   --display-notices ........... Display details for notices triggered by tests  
   --display-warnings ......... Display details for warnings triggered by tests  
+  --display-all-issues ..... Display details for all issues that are triggered  
   --reverse-list .............................. Print defects in reverse order  
   --teamcity . Replace default progress and result output with TeamCity format  
   --testdox ................ Replace default result output with TestDox format  
@@ -105,6 +119,8 @@
   --coverage-html [dir]  Write code coverage report in HTML format to directory  
   --coverage-php [file] .......... Write serialized code coverage data to file  
   --coverage-text=[file]  Write code coverage report in text format to file [default: standard output]  
+  --only-summary-for-coverage-text  Option for code coverage report in text format: only show summary  
+  --show-uncovered-for-coverage-text  Option for code coverage report in text format: show uncovered files  
   --coverage-xml [dir] . Write code coverage report in XML format to directory  
   --warm-coverage-cache ........................... Warm static analysis cache  
   --coverage-filter [dir] ........... Include [dir] in code coverage reporting  

tests/.pest/snapshots/Visual/Version/visual_snapshot_of_help_command_output.snap

@@ -1,3 +1,3 @@
 
-  Pest Testing Framework 2.35.1.  
+  Pest Testing Framework 2.36.1.  
 

tests/.snapshots/success.txt

@@ -1173,16 +1173,6 @@
    PASS  Tests\Hooks\BeforeEachTest
   ✓ global beforeEach execution order
 
-   PASS  Tests\Overrides\VersionsTest
-  ✓ versions with dataset "Runner/Filter/NameFilterIterator.php"
-  ✓ versions with dataset "Runner/ResultCache/DefaultResultCache.php"
-  ✓ versions with dataset "Runner/TestSuiteLoader.php"
-  ✓ versions with dataset "TextUI/Command/Commands/WarmCodeCoverageCacheCommand.php"
-  ✓ versions with dataset "TextUI/Output/Default/ProgressPrinter/Subscriber/TestSkippedSubscriber.php"
-  ✓ versions with dataset "TextUI/TestSuiteFilterProcessor.php"
-  ✓ versions with dataset "Event/Value/ThrowableBuilder.php"
-  ✓ versions with dataset "Logging/JUnit/JunitXmlLogger.php"
-
    PASS  Tests\PHPUnit\CustomAffixes\InvalidTestName
   ✓ it runs file names like @#$%^&()-_=+.php
 
@@ -1287,26 +1277,6 @@
   ✓ it can resolve builtin value types
   ✓ it cannot resolve a parameter without type
 
-   PASS  Tests\Unit\Support\DatasetInfo
-  ✓ it can check if dataset is defined inside a Datasets directory with ('/var/www/project/tests/Datase…rs.php', true)
-  ✓ it can check if dataset is defined inside a Datasets directory with ('/var/www/project/tests/Datasets.php', false)
-  ✓ it can check if dataset is defined inside a Datasets directory with ('/var/www/project/tests/Featur…rs.php', true)
-  ✓ it can check if dataset is defined inside a Datasets directory with ('/var/www/project/tests/Featur…rs.php', false)
-  ✓ it can check if dataset is defined inside a Datasets directory with ('/var/www/project/tests/Featur…ts.php', false)
-  ✓ it can check if dataset is defined inside a Datasets.php file with ('/var/www/project/tests/Datase…rs.php', false)
-  ✓ it can check if dataset is defined inside a Datasets.php file with ('/var/www/project/tests/Datasets.php', true)
-  ✓ it can check if dataset is defined inside a Datasets.php file with ('/var/www/project/tests/Featur…rs.php', false) #1
-  ✓ it can check if dataset is defined inside a Datasets.php file with ('/var/www/project/tests/Featur…rs.php', false) #2
-  ✓ it can check if dataset is defined inside a Datasets.php file with ('/var/www/project/tests/Featur…ts.php', true)
-  ✓ it computes the dataset scope with ('/var/www/project/tests/Datase…rs.php', '/var/www/project/tests')
-  ✓ it computes the dataset scope with ('/var/www/project/tests/Datasets.php', '/var/www/project/tests')
-  ✓ it computes the dataset scope with ('/var/www/project/tests/Featur…rs.php', '/var/www/project/tests/Features')
-  ✓ it computes the dataset scope with ('/var/www/project/tests/Featur…rs.php', '/var/www/project/tests/Featur…rs.php') #1
-  ✓ it computes the dataset scope with ('/var/www/project/tests/Featur…ts.php', '/var/www/project/tests/Features')
-  ✓ it computes the dataset scope with ('/var/www/project/tests/Featur…rs.php', '/var/www/project/tests/Featur…ollers')
-  ✓ it computes the dataset scope with ('/var/www/project/tests/Featur…rs.php', '/var/www/project/tests/Featur…rs.php') #2
-  ✓ it computes the dataset scope with ('/var/www/project/tests/Featur…ts.php', '/var/www/project/tests/Featur…ollers')
-
    PASS  Tests\Unit\Support\ExceptionTrace
   ✓ it ensures the given closures reports the correct class name
   ✓ it ensures the given closures reports the correct class name and suggests the [uses()] function
@@ -1425,4 +1395,4 @@
    WARN  Tests\Visual\Version
   - visual snapshot of help command output
 
-  Tests:    2 deprecated, 4 warnings, 5 incomplete, 2 notices, 13 todos, 20 skipped, 1014 passed (2407 assertions)
+  Tests:    2 deprecated, 4 warnings, 5 incomplete, 2 notices, 13 todos, 20 skipped, 988 passed (2381 assertions)

tests/Overrides/VersionsTest.php

@@ -1,18 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-use Pest\Bootstrappers\BootOverrides;
-
-test('versions', function (string $vendorPath, string $expectedHash) {
-    expect(hash_file('sha256', $vendorPath))->toBe($expectedHash);
-})->with(function () {
-    foreach (BootOverrides::FILES as $hash => $file) {
-        $path = implode(DIRECTORY_SEPARATOR, [
-            dirname(__DIR__, 2),
-            'vendor/phpunit/phpunit/src',
-            $file,
-        ]);
-        yield $file => [$path, $hash];
-    }
-});

tests/Unit/Support/DatasetInfo.php

@@ -1,36 +0,0 @@
-<?php
-
-use Pest\Support\DatasetInfo;
-
-it('can check if dataset is defined inside a Datasets directory', function (string $file, bool $inside) {
-    expect(DatasetInfo::isInsideADatasetsDirectory($file))->toBe($inside);
-})->with([
-    ['file' => '/var/www/project/tests/Datasets/Numbers.php', 'inside' => true],
-    ['file' => '/var/www/project/tests/Datasets.php', 'inside' => false],
-    ['file' => '/var/www/project/tests/Features/Datasets/Numbers.php', 'inside' => true],
-    ['file' => '/var/www/project/tests/Features/Numbers.php', 'inside' => false],
-    ['file' => '/var/www/project/tests/Features/Datasets.php', 'inside' => false],
-]);
-
-it('can check if dataset is defined inside a Datasets.php file', function (string $path, bool $inside) {
-    expect(DatasetInfo::isADatasetsFile($path))->toBe($inside);
-})->with([
-    ['file' => '/var/www/project/tests/Datasets/Numbers.php', 'inside' => false],
-    ['file' => '/var/www/project/tests/Datasets.php', 'inside' => true],
-    ['file' => '/var/www/project/tests/Features/Datasets/Numbers.php', 'inside' => false],
-    ['file' => '/var/www/project/tests/Features/Numbers.php', 'inside' => false],
-    ['file' => '/var/www/project/tests/Features/Datasets.php', 'inside' => true],
-]);
-
-it('computes the dataset scope', function (string $file, string $scope) {
-    expect(DatasetInfo::scope($file))->toBe($scope);
-})->with([
-    ['file' => '/var/www/project/tests/Datasets/Numbers.php', 'scope' => '/var/www/project/tests'],
-    ['file' => '/var/www/project/tests/Datasets.php', 'scope' => '/var/www/project/tests'],
-    ['file' => '/var/www/project/tests/Features/Datasets/Numbers.php', 'scope' => '/var/www/project/tests/Features'],
-    ['file' => '/var/www/project/tests/Features/Numbers.php', 'scope' => '/var/www/project/tests/Features/Numbers.php'],
-    ['file' => '/var/www/project/tests/Features/Datasets.php', 'scope' => '/var/www/project/tests/Features'],
-    ['file' => '/var/www/project/tests/Features/Controllers/Datasets/Numbers.php', 'scope' => '/var/www/project/tests/Features/Controllers'],
-    ['file' => '/var/www/project/tests/Features/Controllers/Numbers.php', 'scope' => '/var/www/project/tests/Features/Controllers/Numbers.php'],
-    ['file' => '/var/www/project/tests/Features/Controllers/Datasets.php', 'scope' => '/var/www/project/tests/Features/Controllers'],
-]);

tests/Visual/Parallel.php

@@ -16,7 +16,7 @@ $run = function () {
 
 test('parallel', function () use ($run) {
     expect($run('--exclude-group=integration'))
-        ->toContain('Tests:    1 deprecated, 4 warnings, 5 incomplete, 2 notices, 13 todos, 16 skipped, 999 passed (2360 assertions)')
+        ->toContain('Tests:    1 deprecated, 4 warnings, 5 incomplete, 2 notices, 13 todos, 16 skipped, 973 passed (2334 assertions)')
         ->toContain('Parallel: 3 processes');
 })->skipOnWindows();