release: v3.2.2

composer.json

@@ -18,12 +18,12 @@
     ],
     "require": {
         "php": "^8.2.0",
-        "brianium/paratest": "^7.5.4",
+        "brianium/paratest": "^7.5.5",
         "nunomaduro/collision": "^8.4.0",
         "nunomaduro/termwind": "^2.1.0",
         "pestphp/pest-plugin": "^3.0.0",
         "pestphp/pest-plugin-arch": "^3.0.0",
-        "pestphp/pest-plugin-mutate": "^3.0.4",
+        "pestphp/pest-plugin-mutate": "^3.0.5",
         "phpunit/phpunit": "^11.3.6"
     },
     "conflict": {
@@ -54,7 +54,7 @@
     "require-dev": {
         "pestphp/pest-dev-tools": "^3.0.0",
         "pestphp/pest-plugin-type-coverage": "^3.0.0",
-        "symfony/process": "^7.1.3"
+        "symfony/process": "^7.1.5"
     },
     "minimum-stability": "dev",
     "prefer-stable": true,

src/ArchPresets/Strict.php

@@ -21,6 +21,7 @@ final class Strict extends AbstractPreset
             fn (Expectation $namespace): ArchExpectation => $namespace->classes()->not->toHaveProtectedMethods(),
             fn (Expectation $namespace): ArchExpectation => $namespace->classes()->not->toBeAbstract(),
             fn (Expectation $namespace): ArchExpectation => $namespace->toUseStrictTypes(),
+            fn (Expectation $namespace): ArchExpectation => $namespace->toUseStrictEquality(),
             fn (Expectation $namespace): ArchExpectation => $namespace->classes()->toBeFinal(),
         );
 

src/Expectation.php

@@ -223,7 +223,7 @@ final class Expectation
             throw new BadMethodCallException('Expectation value is not iterable.');
         }
 
-        if (count($callbacks) == 0) {
+        if ($callbacks === []) {
             throw new InvalidArgumentException('No sequence expectations defined.');
         }
 
@@ -264,7 +264,7 @@ final class Expectation
         $matched = false;
 
         foreach ($expressions as $key => $callback) {
-            if ($subject != $key) {
+            if ($subject != $key) { // @pest-arch-ignore-line
                 continue;
             }
 
@@ -380,7 +380,7 @@ final class Expectation
         if (self::hasExtend($name)) {
             $extend = self::$extends[$name]->bindTo($this, Expectation::class);
 
-            if ($extend != false) {
+            if ($extend != false) { // @pest-arch-ignore-line
                 return $extend;
             }
         }
@@ -515,6 +515,19 @@ final class Expectation
         );
     }
 
+    /**
+     * Asserts that the given expectation target uses strict equality.
+     */
+    public function toUseStrictEquality(): ArchExpectation
+    {
+        return Targeted::make(
+            $this,
+            fn (ObjectDescription $object): bool => ! str_contains((string) file_get_contents($object->path), ' == ') && ! str_contains((string) file_get_contents($object->path), ' != '),
+            'to use strict equality',
+            FileLineFinder::where(fn (string $line): bool => str_contains($line, ' == ') || str_contains($line, ' != ')),
+        );
+    }
+
     /**
      * Asserts that the given expectation target is final.
      */

src/Expectations/OppositeExpectation.php

@@ -152,6 +152,19 @@ final readonly class OppositeExpectation
         );
     }
 
+    /**
+     * Asserts that the given expectation target does not use the strict equality operator.
+     */
+    public function toUseStrictEquality(): ArchExpectation
+    {
+        return Targeted::make(
+            $this->original,
+            fn (ObjectDescription $object): bool => ! str_contains((string) file_get_contents($object->path), ' === ') && ! str_contains((string) file_get_contents($object->path), ' !== '),
+            'to use strict equality',
+            FileLineFinder::where(fn (string $line): bool => str_contains($line, ' === ') || str_contains($line, ' !== ')),
+        );
+    }
+
     /**
      * Asserts that the given expectation target is not final.
      */

src/Logging/Converter.php

@@ -150,7 +150,7 @@ final readonly class Converter
     {
         if ($testSuite instanceof TestSuiteForTestMethodWithDataProvider) {
             $firstTest = $this->getFirstTest($testSuite);
-            if ($firstTest != null) {
+            if ($firstTest instanceof \PHPUnit\Event\Code\TestMethod) {
                 return $this->getTestMethodNameWithoutDatasetSuffix($firstTest);
             }
         }
@@ -178,7 +178,7 @@ final readonly class Converter
     public function getTestSuiteLocation(TestSuite $testSuite): ?string
     {
         $firstTest = $this->getFirstTest($testSuite);
-        if ($firstTest == null) {
+        if (! $firstTest instanceof \PHPUnit\Event\Code\TestMethod) {
             return null;
         }
         $path = $firstTest->testDox()->prettifiedClassName();

src/PendingCalls/TestCall.php

@@ -5,6 +5,7 @@ declare(strict_types=1);
 namespace Pest\PendingCalls;
 
 use Closure;
+use Pest\Concerns\Testable;
 use Pest\Exceptions\InvalidArgumentException;
 use Pest\Exceptions\TestDescriptionMissing;
 use Pest\Factories\Attribute;
@@ -25,9 +26,9 @@ use PHPUnit\Framework\TestCase;
 /**
  * @internal
  *
- * @mixin HigherOrderCallables|TestCase
+ * @mixin HigherOrderCallables|TestCase|Testable
  */
-final class TestCall
+final class TestCall // @phpstan-ignore-line
 {
     use Describable;
 

src/Pest.php

@@ -6,7 +6,7 @@ namespace Pest;
 
 function version(): string
 {
-    return '3.1.0';
+    return '3.2.2';
 }
 
 function testDirectory(string $file = ''): string

src/Support/Closure.php

@@ -20,13 +20,13 @@ final class Closure
      */
     public static function bind(?BaseClosure $closure, ?object $newThis, object|string|null $newScope = 'static'): BaseClosure
     {
-        if ($closure == null) {
+        if (! $closure instanceof \Closure) {
             throw ShouldNotHappen::fromMessage('Could not bind null closure.');
         }
 
         $closure = BaseClosure::bind($closure, $newThis, $newScope);
 
-        if ($closure == false) {
+        if (! $closure instanceof \Closure) {
             throw ShouldNotHappen::fromMessage('Could not bind closure.');
         }
 

tests/.pest/snapshots/Visual/Help/visual_snapshot_of_help_command_output.snap

@@ -1,5 +1,5 @@
 
-  Pest Testing Framework 3.1.0.  
+  Pest Testing Framework 3.2.2.  
 
   USAGE: pest <file> [options]  
 

tests/.pest/snapshots/Visual/Version/visual_snapshot_of_help_command_output.snap

@@ -1,3 +1,3 @@
 
-  Pest Testing Framework 3.1.0.  
+  Pest Testing Framework 3.2.2.  
 

tests/.snapshots/success.txt

@@ -968,6 +968,12 @@
   ✓ it can handle a non-defined exception
   ✓ it can handle a class not found Error
 
+   PASS  Tests\Features\Expect\toUseStrictEquality
+  ✓ missing strict equality
+  ✓ has strict equality
+  ✓ opposite missing strict equality
+  ✓ opposite has strict equality
+
    PASS  Tests\Features\Expect\toUseTrait
   ✓ pass
   ✓ failures
@@ -1574,4 +1580,4 @@
    WARN  Tests\Visual\Version
   - visual snapshot of help command output
 
-  Tests:    2 deprecated, 4 warnings, 5 incomplete, 2 notices, 17 todos, 28 skipped, 1089 passed (2637 assertions)
+  Tests:    2 deprecated, 4 warnings, 5 incomplete, 2 notices, 17 todos, 28 skipped, 1093 passed (2644 assertions)

tests/Features/Expect/toUseStrictEquality.php

@@ -0,0 +1,21 @@
+<?php
+
+use Pest\Arch\Exceptions\ArchExpectationFailedException;
+
+test('missing strict equality')
+    ->throws(ArchExpectationFailedException::class)
+    ->expect('Tests\\Fixtures\\Arch\\ToUseStrictEquality\\NotStrictEquality')
+    ->toUseStrictEquality();
+
+test('has strict equality')
+    ->expect('Tests\\Fixtures\\Arch\\ToUseStrictEquality\\StrictEquality')
+    ->toUseStrictEquality();
+
+test('opposite missing strict equality')
+    ->throws(ArchExpectationFailedException::class)
+    ->expect('Tests\\Fixtures\\Arch\\ToUseStrictEquality\\StrictEquality')
+    ->not->toUseStrictEquality();
+
+test('opposite has strict equality')
+    ->expect('Tests\\Fixtures\\Arch\\ToUseStrictEquality\\NotStrictEquality')
+    ->not->toUseStrictEquality();

tests/Fixtures/Arch/ToUseStrictEquality/NotStrictEquality.php

@@ -0,0 +1,22 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Fixtures\Arch\ToUseStrictEquality;
+
+class NotStrictEquality
+{
+    public function test(): void
+    {
+        $a = 1;
+        $b = '1';
+
+        if ($a == $b) {
+            echo 'Equal';
+        }
+
+        if ($a != $b) {
+            echo 'Equal';
+        }
+    }
+}

tests/Fixtures/Arch/ToUseStrictEquality/StrictEquality.php

@@ -0,0 +1,22 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Fixtures\Arch\ToUseStrictEquality;
+
+class StrictEquality
+{
+    public function test(): void
+    {
+        $a = 1;
+        $b = '1';
+
+        if ($a === $b) {
+            echo 'Equal';
+        }
+
+        if ($a !== $b) {
+            echo 'Equal';
+        }
+    }
+}

tests/Visual/Parallel.php

@@ -16,7 +16,7 @@ $run = function () {
 
 test('parallel', function () use ($run) {
     expect($run('--exclude-group=integration'))
-        ->toContain('Tests:    2 deprecated, 4 warnings, 5 incomplete, 2 notices, 17 todos, 19 skipped, 1079 passed (2613 assertions)')
+        ->toContain('Tests:    2 deprecated, 4 warnings, 5 incomplete, 2 notices, 17 todos, 19 skipped, 1083 passed (2620 assertions)')
         ->toContain('Parallel: 3 processes');
 })->skipOnWindows();