fix: static callable datasets

src/Plugins/Tia/Fingerprint.php

@@ -40,7 +40,7 @@ final readonly class Fingerprint
                 'js_config' => self::jsConfigHash($projectRoot),
             ],
             'environmental' => [
-                'php_minor' => PHP_MAJOR_VERSION,
+                'php_minor' => PHP_MAJOR_VERSION.'.'.PHP_MINOR_VERSION,
 
             ],
         ];

src/Plugins/Tia/ResultCollector.php

@@ -117,7 +117,7 @@ final class ResultCollector
 
     public function hasUnfinishedTest(): bool
     {
-        return $this->currentTestId !== null;
+        return $this->currentTestId !== null && ! isset($this->results[$this->currentTestId]);
     }
 
     public function recordAssertions(string $testId, int $assertions): void

src/Repositories/DatasetsRepository.php

@@ -141,7 +141,7 @@ final class DatasetsRepository
                 $datasets[$index] = self::getScopedDataset($data, $currentTestFile);
             }
 
-            if (is_callable($datasets[$index])) {
+            if (! is_array($datasets[$index]) && is_callable($datasets[$index])) {
                 $datasets[$index] = call_user_func($datasets[$index]);
             }
 

tests/.snapshots/success.txt

@@ -1764,6 +1764,7 @@
   ✓ it shows the correct description for long texts with newlines
   ✓ it shows the correct description for arrays with many elements
   ✓ it shows the correct description of datasets with html
+  ✓ it does not treat a two element dataset of class names as a callable
 
    PASS  Tests\Unit\Expectations\OppositeExpectation
   ✓ it throw expectation failed exception with string argument
@@ -2225,4 +2226,4 @@
   ✓ pass with dataset with ('my-datas-set-value')
   ✓ within describe → pass with dataset with ('my-datas-set-value')
 
-  Tests:    2 deprecated, 4 warnings, 5 incomplete, 2 notices, 40 todos, 35 skipped, 1572 passed (3413 assertions)
+  Tests:    2 deprecated, 4 warnings, 5 incomplete, 2 notices, 40 todos, 35 skipped, 1573 passed (3414 assertions)

tests/Features/Tia/CompleteRunWriteTier.php

@@ -33,6 +33,34 @@ test('a complete run prunes a deleted test', function (array $arguments): void {
         ->and($delta->structureMoved())->toBeFalse($delta->summary());
 })->with(Project::SEQUENTIAL_AND_PARALLEL)->skipOnWindows();
 
+test('a complete run stays complete when the last test is skipped from a hook', function (array $arguments): void {
+    $project = Project::make('master');
+    $project->seed('master');
+
+    $project->write('tests/Unit/GreeterTest.php', <<<'PHP'
+        <?php
+
+        declare(strict_types=1);
+
+        use Fixture\App\Greeter;
+
+        beforeEach(function (): void {
+            test()->markTestSkipped('not today');
+        });
+
+        test('greets a person', function (): void {
+            expect((new Greeter)->greet('Nuno'))->toBe('Hello, Nuno!');
+        });
+        PHP);
+
+    $result = $project->pest(...$arguments);
+    $delta = $project->delta();
+
+    expect($result->tally())->toContain('1 skipped')
+        ->and($delta->removed())->toBe(1, $delta->summary())
+        ->and($delta->added())->toBe(0, $delta->summary());
+})->with(Project::SEQUENTIAL_AND_PARALLEL)->skipOnWindows();
+
 test('a complete run records nothing for a test file the graph does not know', function (): void {
     $project = Project::make('master');
     $project->seed('master');

tests/Unit/DatasetsTests.php

@@ -109,3 +109,27 @@ it('shows the correct description of datasets with html', function (): void {
 
     expect($descriptions[0])->toBe('(\'<div class="flex items-center"></div>\')');
 });
+
+it('does not treat a two element dataset of class names as a callable', function (): void {
+    $datasets = DatasetsRepository::resolve([
+        [
+            MagicCallDataset::class,
+            AnotherMagicCallDataset::class,
+        ],
+    ], __FILE__);
+
+    expect(array_values($datasets))->toBe([
+        [MagicCallDataset::class],
+        [AnotherMagicCallDataset::class],
+    ]);
+});
+
+class MagicCallDataset
+{
+    public static function __callStatic(string $name, array $arguments): void
+    {
+        throw new RuntimeException('This dataset should not be called.');
+    }
+}
+
+class AnotherMagicCallDataset {}

tests/Visual/Parallel.php

@@ -26,13 +26,13 @@ test('parallel', function () use ($run): void {
         $file = file_get_contents(__FILE__);
         $file = preg_replace(
             '/\$expected = \'.*?\';/',
-            "\$expected = '2 deprecated, 4 warnings, 5 incomplete, 3 notices, 40 todos, 27 skipped, 1554 passed (3358 assertions)';",
+            "\$expected = '2 deprecated, 4 warnings, 5 incomplete, 3 notices, 40 todos, 27 skipped, 1555 passed (3359 assertions)';",
             $file,
         );
         file_put_contents(__FILE__, $file);
     }
 
-    $expected = '2 deprecated, 4 warnings, 5 incomplete, 3 notices, 40 todos, 27 skipped, 1554 passed (3358 assertions)';
+    $expected = '2 deprecated, 4 warnings, 5 incomplete, 3 notices, 40 todos, 27 skipped, 1555 passed (3359 assertions)';
 
     expect($output)
         ->toContain("Tests:    {$expected}")