19 Commits

Author SHA1 Message Date
Conor Murphy ac8feafdcc fix: guard Tia argv scanning against non-string args (#1736)
The Tia plugin scans the raw argv with str_starts_with() in
argumentPresent() and hasExplicitPathArgument(). In the parallel worker
path (bin/worker.php) the unserialized argv can contain an integer
--random-order-seed value as a separate element, which made
str_starts_with() throw:

    TypeError: str_starts_with(): Argument #1 ($haystack) must be of
    type string, int given

This is the same class of bug as #1206, which was only fixed in
HandleArguments; it resurfaced in the newer Tia plugin. Cast each argv
element to string before scanning, mirroring the #1206 fix.

Adds a regression test, and updates the parallel count assertion and the
success snapshot to account for it.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 20:03:06 +01:00
nuno maduro 9e4cf4b665 wip 2026-05-02 18:58:42 +01:00
nuno maduro 4280233b40 wip 2026-05-02 18:37:24 +01:00
Nuno Maduro 45cce6ce93 Style 2024-07-24 21:54:52 +01:00
Marek Mencl f004591c5a fix: checking existing argument with equal sign 2024-01-02 15:03:46 +01:00
Nuno Maduro 052b9e051b fix: --retry with parallel 2023-02-11 17:39:46 +00:00
Nuno Maduro d69f61c8d3 refacto: --retry option 2023-02-11 16:48:06 +00:00
Nuno Maduro 0e0e2adfbe Fixes --version and --help 2022-09-17 23:47:47 +01:00
Nuno Maduro e9564febaf Migrates to Pint 2022-09-16 10:45:53 +01:00
Fabio Ivona 1706e1d2e0 fix lint 2022-08-02 11:01:17 +02:00
Nuno Maduro 106b279ed0 feat: adds --retry option 2021-12-04 21:18:55 +00:00
Nuno Maduro 7f38de11b7 refactor: --ci option 2021-09-25 13:29:11 +01:00
Fabio Ivona 601c4b01fc refactors to use a Plugin to parse --ci option 2021-09-22 14:53:16 +02:00
Owen Voke 09a0a64f20 tests: update to use version() in test 2020-08-19 16:56:40 +01:00
Nuno Maduro 832882160f feat(expect): updates test suite to use expectation api 2020-07-14 23:15:14 +02:00
Nuno Maduro db7c4b174f refactor: thanks 2020-07-01 20:23:00 +02:00
Owen Voke 8e203e914e Add test for --thanks 2020-07-01 10:27:12 +01:00
Nuno Maduro a3644f7efa tests: fixes windows tests 2020-06-26 18:42:57 +02:00
Nuno Maduro 9ea51caf3f feat: adds --version option 2020-06-26 18:17:11 +02:00