chore: type checking

This commit is contained in:
Nuno Maduro
2023-03-02 22:58:11 +00:00
parent b939d94cda
commit f68e6cefd4
2 changed files with 9 additions and 8 deletions

View File

@ -42,9 +42,9 @@ declare(strict_types=1);
* For the full copyright and license information, please view the LICENSE * For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code. * file that was distributed with this source code.
*/ */
namespace PHPUnit\TextUI\Command; namespace PHPUnit\TextUI\Command;
use function printf;
use PHPUnit\TextUI\Configuration\CodeCoverageFilterRegistry; use PHPUnit\TextUI\Configuration\CodeCoverageFilterRegistry;
use PHPUnit\TextUI\Configuration\Configuration; use PHPUnit\TextUI\Configuration\Configuration;
use PHPUnit\TextUI\Configuration\NoCoverageCacheDirectoryException; use PHPUnit\TextUI\Configuration\NoCoverageCacheDirectoryException;
@ -58,6 +58,7 @@ use SebastianBergmann\Timer\Timer;
final class WarmCodeCoverageCacheCommand implements Command final class WarmCodeCoverageCacheCommand implements Command
{ {
private readonly Configuration $configuration; private readonly Configuration $configuration;
private readonly CodeCoverageFilterRegistry $codeCoverageFilterRegistry; private readonly CodeCoverageFilterRegistry $codeCoverageFilterRegistry;
public function __construct(Configuration $configuration, CodeCoverageFilterRegistry $codeCoverageFilterRegistry) public function __construct(Configuration $configuration, CodeCoverageFilterRegistry $codeCoverageFilterRegistry)
@ -72,18 +73,18 @@ final class WarmCodeCoverageCacheCommand implements Command
*/ */
public function execute(): Result public function execute(): Result
{ {
if (!$this->configuration->hasCoverageCacheDirectory()) { if (! $this->configuration->hasCoverageCacheDirectory()) {
return Result::from( return Result::from(
'Cache for static analysis has not been configured' . PHP_EOL, 'Cache for static analysis has not been configured'.PHP_EOL,
Result::FAILURE Result::FAILURE
); );
} }
$this->codeCoverageFilterRegistry->init($this->configuration); $this->codeCoverageFilterRegistry->init($this->configuration);
if (!$this->codeCoverageFilterRegistry->configured()) { if (! $this->codeCoverageFilterRegistry->configured()) {
return Result::from( return Result::from(
'Filter for code coverage has not been configured' . PHP_EOL, 'Filter for code coverage has not been configured'.PHP_EOL,
Result::FAILURE Result::FAILURE
); );
} }
@ -93,7 +94,7 @@ final class WarmCodeCoverageCacheCommand implements Command
(new CacheWarmer)->warmCache( (new CacheWarmer)->warmCache(
$this->configuration->coverageCacheDirectory(), $this->configuration->coverageCacheDirectory(),
!$this->configuration->disableCodeCoverageIgnore(), ! $this->configuration->disableCodeCoverageIgnore(),
$this->configuration->ignoreDeprecatedCodeUnitsFromCodeCoverage(), $this->configuration->ignoreDeprecatedCodeUnitsFromCodeCoverage(),
$this->codeCoverageFilterRegistry->get() $this->codeCoverageFilterRegistry->get()
); );

View File

@ -36,7 +36,7 @@ final class Cache implements HandlesArguments
); );
if (! $this->hasArgument('--parallel', $arguments)) { if (! $this->hasArgument('--parallel', $arguments)) {
$arguments = $this->pushArgument('--cache-result', $arguments); return $this->pushArgument('--cache-result', $arguments);
} }
return $arguments; return $arguments;