feat(presets): refactors code

src/ArchPresets/AbstractPreset.php

@@ -0,0 +1,54 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Pest\ArchPresets;
+
+use Pest\Arch\Contracts\ArchExpectation;
+
+/**
+ * @internal
+ */
+abstract class AbstractPreset
+{
+    /**
+     * Creates a new preset instance.
+     *
+     * @param  array<int, string>  $userNamespaces
+     * @param  array<int, ArchExpectation>  $expectations
+     */
+    final public function __construct(// @phpstan-ignore-line
+        protected array $userNamespaces,
+        protected array $expectations = [],
+    ) {
+        //
+    }
+
+    /**
+     * Executes the arch preset.
+     *
+     * @internal
+     */
+    abstract public function execute(): void;
+
+    /**
+     * Ignores the given "targets" or "dependencies".
+     *
+     * @param  array<int, string>|string  $targetsOrDependencies
+     */
+    final public function ignoring(array|string $targetsOrDependencies): void
+    {
+        $this->expectations = array_map(
+            fn (ArchExpectation $expectation): \Pest\Arch\Contracts\ArchExpectation => $expectation->ignoring($targetsOrDependencies),
+            $this->expectations,
+        );
+    }
+
+    /**
+     * Flushes the expectations.
+     */
+    final public function flush(): void
+    {
+        $this->expectations = [];
+    }
+}

src/ArchPresets/Base.php

@@ -4,24 +4,17 @@ declare(strict_types=1);
 
 namespace Pest\ArchPresets;
 
-use Pest\Arch\Contracts\ArchExpectation;
-use Pest\Contracts\ArchPreset;
-use Pest\PendingCalls\TestCall;
-
 /**
  * @internal
  */
-final class Base implements ArchPreset
+final class Base extends AbstractPreset
 {
     /**
-     * Boots the arch preset.
-     *
-     * @param  array<string>  $baseNamespace
+     * Executes the arch preset.
      */
-    public function boot(TestCall $testCall, array $baseNamespace): TestCall|ArchExpectation
+    public function execute(): void
     {
-        return $testCall // @phpstan-ignore-line
-            ->expect(['dd', 'dump', 'ray', 'die', 'var_dump', 'sleep', 'eval', 'ini_set'])
+        $this->expectations[] = expect(['dd', 'dump', 'ray', 'die', 'var_dump', 'sleep', 'eval', 'ini_set'])
             ->not
             ->toBeUsed();
     }

src/ArchPresets/Strict.php

@@ -4,25 +4,19 @@ declare(strict_types=1);
 
 namespace Pest\ArchPresets;
 
-use Pest\Arch\Contracts\ArchExpectation;
-use Pest\Contracts\ArchPreset;
-use Pest\PendingCalls\TestCall;
-
 /**
  * @internal
  */
-final class Strict implements ArchPreset
+final class Strict extends AbstractPreset
 {
     /**
-     * Boots the arch preset.
-     *
-     * @param  array<string>  $baseNamespaces
+     * Executes the arch preset.
      */
-    public function boot(TestCall $testCall, array $baseNamespaces): TestCall|ArchExpectation
+    public function execute(): void
     {
-        return $testCall // @phpstan-ignore-line
-            ->expect($baseNamespaces)
-            ->each
+        foreach ($this->userNamespaces as $namespace) {
+            $this->expectations[] = expect($namespace)
                 ->toUseStrictTypes();
         }
+    }
 }

src/Contracts/ArchPreset.php

@@ -4,18 +4,9 @@ declare(strict_types=1);
 
 namespace Pest\Contracts;
 
-use Pest\Arch\Contracts\ArchExpectation;
-use Pest\PendingCalls\TestCall;
-
 /**
  * @internal
  */
 interface ArchPreset
 {
-    /**
-     * Boots the arch preset.
-     *
-     * @param  array<int, string>  $baseNamespaces
-     */
-    public function boot(TestCall $testCall, array $baseNamespaces): TestCall|ArchExpectation;
 }

src/Preset.php

@@ -4,9 +4,12 @@ declare(strict_types=1);
 
 namespace Pest;
 
-use Pest\Arch\Contracts\ArchExpectation;
 use Pest\Arch\Support\Composer;
+use Pest\ArchPresets\AbstractPreset;
+use Pest\ArchPresets\Base;
+use Pest\ArchPresets\Strict;
 use Pest\PendingCalls\TestCall;
+use stdClass;
 
 /**
  * @internal
@@ -31,19 +34,44 @@ final class Preset
     /**
      * Uses the Pest base preset and returns the test call instance.
      */
-    public function base(): TestCall|ArchExpectation
+    public function base(): Base
     {
-        return (new ArchPresets\Base)->boot($this->testCall, $this->baseNamespaces());
+        return $this->executePreset(new Base($this->baseNamespaces()));
     }
 
     /**
      * Uses the Pest strict preset and returns the test call instance.
      */
-    public function strict(): TestCall
+    public function strict(): Strict
     {
-        (new ArchPresets\Strict)->boot($this->testCall, $this->baseNamespaces());
+        return $this->executePreset(new Strict($this->baseNamespaces()));
+    }
 
-        return $this->testCall;
+    /**
+     * Executes the given preset.
+     *
+     * @template TPreset of AbstractPreset
+     *
+     * @param  TPreset  $preset
+     * @return TPreset
+     */
+    private function executePreset(AbstractPreset $preset): AbstractPreset
+    {
+        if ((fn (): ?string => $this->description)->call($this->testCall) === null) {
+            $description = strtolower((new \ReflectionClass($preset))->getShortName());
+
+            (fn (): string => $this->description = sprintf('arch "%s" preset', $description))->call($this->testCall);
+        }
+
+        $this->baseNamespaces();
+
+        $preset->execute();
+
+        $this->testCall->testCaseMethod->closure = (function () use ($preset): void {
+            $preset->flush();
+        })->bindTo(new stdClass);
+
+        return $preset;
     }
 
     /**

tests/.snapshots/success.txt

@@ -1,7 +1,7 @@
 
    PASS  Tests\Arch
-  ✓ expect ['dd', 'dump', 'ray', …] → not → toBeUsed → ignoring 'Pest\Expectation'
-  ✓ expect ['Pest'] → each → toUseStrictTypes
+  ✓ arch "base" preset
+  ✓ arch "strict" preset
   ✓ globals
   ✓ dependencies
   ✓ contracts
@@ -1268,7 +1268,7 @@
   ✓ closure was bound to CustomTestCase
 
    PASS  Tests\Playground
-  ✓ expect ['Pest'] → each → toUseStrictTypes
+  ✓ basic
 
    PASS  Tests\Plugins\Traits
   ✓ it allows global uses

tests/Playground.php

@@ -1,3 +1,5 @@
 <?php
 
-arch()->preset()->strict();
+test('basic', function () {
+    expect(true)->toBeTrue();
+});