SADM/pest
1
0
Fork 0
mirror of https://github.com/pestphp/pest.git synced 2026-04-21 22:47:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

chore: style

Browse Source
This commit is contained in:
nuno maduro
2026-04-14 09:17:18 -07:00
parent 985dadd934
commit cb5f6e1bd2
1 changed files with 19 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
src/Plugins/Shard.php
View File

@ -9,8 +9,8 @@ use Pest\Contracts\Plugins\HandlesArguments;
use Pest\Contracts\Plugins\Terminable; use Pest\Contracts\Plugins\Terminable;
use Pest\Exceptions\InvalidOption; use Pest\Exceptions\InvalidOption;
use Pest\Subscribers\EnsureShardTimingFinished; use Pest\Subscribers\EnsureShardTimingFinished;
use Pest\Subscribers\EnsureShardTimingStarted;
use Pest\Subscribers\EnsureShardTimingsAreCollected; use Pest\Subscribers\EnsureShardTimingsAreCollected;
use Pest\Subscribers\EnsureShardTimingStarted;
use Pest\TestSuite; use Pest\TestSuite;
use PHPUnit\Event; use PHPUnit\Event;
use Symfony\Component\Console\Input\ArgvInput; use Symfony\Component\Console\Input\ArgvInput;
@ -108,7 +108,7 @@ final class Shard implements AddsOutput, HandlesArguments, Terminable
/** @phpstan-ignore-next-line */ /** @phpstan-ignore-next-line */
$tests = $this->allTests($arguments); $tests = $this->allTests($arguments);
$timings = self::loadShardsFile(); $timings = $this->loadShardsFile();
if ($timings !== null) { if ($timings !== null) {
$missingTests = array_diff($tests, array_keys($timings)); $missingTests = array_diff($tests, array_keys($timings));
@ -116,7 +116,7 @@ final class Shard implements AddsOutput, HandlesArguments, Terminable
throw new InvalidOption('The [tests/.pest/shards.json] file is out of date. Run [--update-shards] to update it.'); throw new InvalidOption('The [tests/.pest/shards.json] file is out of date. Run [--update-shards] to update it.');
} }
$partitions = self::partitionByTime($tests, $timings, $total); $partitions = $this->partitionByTime($tests, $timings, $total);
$testsToRun = $partitions[$index - 1] ?? []; $testsToRun = $partitions[$index - 1] ?? [];
self::$timeBalanced = true; self::$timeBalanced = true;
} else { } else {
@ -210,7 +210,7 @@ final class Shard implements AddsOutput, HandlesArguments, Terminable
public function addOutput(int $exitCode): int public function addOutput(int $exitCode): int
{ {
if (self::$updateShards && ! Parallel::isWorker()) { if (self::$updateShards && ! Parallel::isWorker()) {
self::$collectedTimings = self::collectTimings(); self::$collectedTimings = $this->collectTimings();
$count = self::$knownTests !== null $count = self::$knownTests !== null
? count(array_intersect_key(self::$collectedTimings, array_flip(self::$knownTests))) ? count(array_intersect_key(self::$collectedTimings, array_flip(self::$knownTests)))
@ -263,18 +263,18 @@ final class Shard implements AddsOutput, HandlesArguments, Terminable
} }
if (Parallel::isWorker()) { if (Parallel::isWorker()) {
self::writeWorkerTimings(); $this->writeWorkerTimings();
return; return;
} }
$timings = self::$collectedTimings ?? self::collectTimings(); $timings = self::$collectedTimings ?? $this->collectTimings();
if ($timings === []) { if ($timings === []) {
return; return;
} }
self::writeTimings($timings); $this->writeTimings($timings);
} }
/** /**
@ -282,12 +282,12 @@ final class Shard implements AddsOutput, HandlesArguments, Terminable
* *
* @return array<string, float> * @return array<string, float>
*/ */
private static function collectTimings(): array private function collectTimings(): array
{ {
$runId = Parallel::getGlobal('SHARD_RUN_ID'); $runId = Parallel::getGlobal('SHARD_RUN_ID');
if (is_string($runId)) { if (is_string($runId)) {
return self::readWorkerTimings($runId); return $this->readWorkerTimings($runId);
} }
return EnsureShardTimingsAreCollected::timings(); return EnsureShardTimingsAreCollected::timings();
@ -296,7 +296,7 @@ final class Shard implements AddsOutput, HandlesArguments, Terminable
/** /**
* Writes the current worker's timing data to a temp file. * Writes the current worker's timing data to a temp file.
*/ */
private static function writeWorkerTimings(): void private function writeWorkerTimings(): void
{ {
$timings = EnsureShardTimingsAreCollected::timings(); $timings = EnsureShardTimingsAreCollected::timings();
@ -320,7 +320,7 @@ final class Shard implements AddsOutput, HandlesArguments, Terminable
* *
* @return array<string, float> * @return array<string, float>
*/ */
private static function readWorkerTimings(string $runId): array private function readWorkerTimings(string $runId): array
{ {
$pattern = sys_get_temp_dir().DIRECTORY_SEPARATOR.'__pest_sharding_'.$runId.'-*.json'; $pattern = sys_get_temp_dir().DIRECTORY_SEPARATOR.'__pest_sharding_'.$runId.'-*.json';
$files = glob($pattern); $files = glob($pattern);
@ -353,7 +353,7 @@ final class Shard implements AddsOutput, HandlesArguments, Terminable
/** /**
* Returns the path to shards.json. * Returns the path to shards.json.
*/ */
private static function shardsPath(): string private function shardsPath(): string
{ {
$testSuite = TestSuite::getInstance(); $testSuite = TestSuite::getInstance();
@ -365,9 +365,9 @@ final class Shard implements AddsOutput, HandlesArguments, Terminable
* *
* @return array<string, float>|null * @return array<string, float>|null
*/ */
private static function loadShardsFile(): ?array private function loadShardsFile(): ?array
{ {
$path = self::shardsPath(); $path = $this->shardsPath();
if (! file_exists($path)) { if (! file_exists($path)) {
return null; return null;
@ -385,7 +385,6 @@ final class Shard implements AddsOutput, HandlesArguments, Terminable
throw new InvalidOption('The [tests/.pest/shards.json] file is corrupted. Delete it or run [--update-shards] to regenerate.'); throw new InvalidOption('The [tests/.pest/shards.json] file is corrupted. Delete it or run [--update-shards] to regenerate.');
} }
/** @var array<string, float> */
return $data['timings']; return $data['timings'];
} }
@ -396,14 +395,14 @@ final class Shard implements AddsOutput, HandlesArguments, Terminable
* @param array<string, float> $timings * @param array<string, float> $timings
* @return list<list<string>> * @return list<list<string>>
*/ */
private static function partitionByTime(array $tests, array $timings, int $total): array private function partitionByTime(array $tests, array $timings, int $total): array
{ {
$knownTimings = array_filter( $knownTimings = array_filter(
array_map(fn (string $test): ?float => $timings[$test] ?? null, $tests), array_map(fn (string $test): ?float => $timings[$test] ?? null, $tests),
fn (?float $t): bool => $t !== null, fn (?float $t): bool => $t !== null,
); );
$median = $knownTimings !== [] ? self::median(array_values($knownTimings)) : 1.0; $median = $knownTimings !== [] ? $this->median(array_values($knownTimings)) : 1.0;
$testsWithTimings = array_map( $testsWithTimings = array_map(
fn (string $test): array => ['test' => $test, 'time' => $timings[$test] ?? $median], fn (string $test): array => ['test' => $test, 'time' => $timings[$test] ?? $median],
@ -433,7 +432,7 @@ final class Shard implements AddsOutput, HandlesArguments, Terminable
* *
* @param list<float> $values * @param list<float> $values
*/ */
private static function median(array $values): float private function median(array $values): float
{ {
sort($values); sort($values);
@ -452,9 +451,9 @@ final class Shard implements AddsOutput, HandlesArguments, Terminable
* *
* @param array<string, float> $timings * @param array<string, float> $timings
*/ */
private static function writeTimings(array $timings): void private function writeTimings(array $timings): void
{ {
$path = self::shardsPath(); $path = $this->shardsPath();
$directory = dirname($path); $directory = dirname($path);
if (! is_dir($directory)) { if (! is_dir($directory)) {