SADM/pest
1
0
Fork 0
mirror of https://github.com/pestphp/pest.git synced 2026-03-11 02:07:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix an issue where beforeEach/afterEach functions were called on other describe blocks with the same name

Browse Source
This commit is contained in:
jshayes
2024-10-12 01:06:16 -04:00
parent 709ecb1ba2
commit b5b8fab09b
17 changed files with 1443 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
tests/Features/AfterEach.php
View File

@ -48,3 +48,55 @@ describe('outer', function () {
});
});
});
describe('matching describe block names', function () {
afterEach(function () {
$this->state->foo = 1;
});
describe('outer', function () {
afterEach(function () {
$this->state->foo++;
});
describe('middle', function () {
afterEach(function () {
$this->state->foo++;
});
describe('inner', function () {
afterEach(function () {
$this->state->foo++;
});
it('does not get executed before the test', function () {
expect($this)->not->toHaveProperty('foo');
});
it('should call all parent afterEach functions', function () {
expect($this->state->foo)->toBe(4);
});
});
});
describe('middle', function () {
it('does not get executed before the test', function () {
expect($this)->not->toHaveProperty('foo');
});
it('should not call afterEach functions for sibling describe blocks with the same name', function () {
expect($this)->not->toHaveProperty('foo');
});
});
describe('inner', function () {
it('does not get executed before the test', function () {
expect($this)->not->toHaveProperty('foo');
});
it('should not call afterEach functions for descendent of sibling describe blocks with the same name', function () {
expect($this)->not->toHaveProperty('foo');
});
});
});
});