SADM/pest
1
0
Fork 0
mirror of https://github.com/pestphp/pest.git synced 2026-03-07 00:07:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

chore: phpstan level 5

Browse Source
This commit is contained in:
Nuno Maduro
2021-11-14 21:39:24 +00:00
parent 183f975166
commit b2cd60395f
11 changed files with 24 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/Factories/TestCaseFactory.php
View File

@ -71,11 +71,13 @@ final class TestCaseFactory
public function make(): void
{
$methods = array_filter($this->methods, function ($method) {
return count($onlyTestCases = $this->methodsUsingOnly()) === 0 || in_array($method, $onlyTestCases, true);
$methodsUsingOnly = $this->methodsUsingOnly();
$methods = array_filter($this->methods, function ($method) use ($methodsUsingOnly) {
return count($methodsUsingOnly) === 0 || in_array($method, $methodsUsingOnly, true);
});
if (count($this->methods) > 0) {
if (count($methods) > 0) {
$this->evaluate($this->filename, $methods);
}
}
@ -91,7 +93,7 @@ final class TestCaseFactory
return [];
}
return array_filter($this->methods, static fn ($method): bool => $method->only);
return array_values(array_filter($this->methods, static fn ($method): bool => $method->only));
}
/**
@ -147,7 +149,7 @@ final class TestCaseFactory
$annotations = (new $annotation())->add($method, $annotations);
}
if (!empty($method->datasets)) {
if (count($method->datasets) > 0) {
$dataProviderName = $methodName . '_dataset';
$annotations[] = "@dataProvider $dataProviderName";
@ -214,7 +216,7 @@ EOF;
throw ShouldNotHappen::fromMessage('The test description may not be empty.');
}
if (isset($this->methods[$method->description])) {
if (array_key_exists($method->description, $this->methods)) {
throw new TestAlreadyExist($method->filename, $method->description);
}