From ac8feafdccdbf6a35b9c3c8dc1adc9fa11e27913 Mon Sep 17 00:00:00 2001
From: Conor Murphy <conormurphyis@gmail.com>
Date: Fri, 26 Jun 2026 05:03:06 +1000
Subject: [PATCH] fix: guard Tia argv scanning against non-string args (#1736)

The Tia plugin scans the raw argv with str_starts_with() in
argumentPresent() and hasExplicitPathArgument(). In the parallel worker
path (bin/worker.php) the unserialized argv can contain an integer
--random-order-seed value as a separate element, which made
str_starts_with() throw:

    TypeError: str_starts_with(): Argument #1 ($haystack) must be of
    type string, int given

This is the same class of bug as #1206, which was only fixed in
HandleArguments; it resurfaced in the newer Tia plugin. Cast each argv
element to string before scanning, mirroring the #1206 fix.

Adds a regression test, and updates the parallel count assertion and the
success snapshot to account for it.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
---
 src/Plugins/Tia.php                        |  4 +++-
 tests/.snapshots/success.txt               |  6 +++++-
 tests/Unit/Plugins/Tia/IsEnabledForRun.php | 20 ++++++++++++++++++++
 tests/Visual/Parallel.php                  |  4 ++--
 4 files changed, 30 insertions(+), 4 deletions(-)
 create mode 100644 tests/Unit/Plugins/Tia/IsEnabledForRun.php

diff --git a/src/Plugins/Tia.php b/src/Plugins/Tia.php
index 6e6a83d8..ef6c083a 100644
--- a/src/Plugins/Tia.php
+++ b/src/Plugins/Tia.php
@@ -251,7 +251,7 @@ final class Tia implements AddsOutput, HandlesArguments, Terminable
                 return true;
             }
 
-            if (str_starts_with($arg, "$argument=")) {
+            if (str_starts_with((string) $arg, "$argument=")) { // @phpstan-ignore-line
                 return true;
             }
         }
@@ -1489,6 +1489,8 @@ final class Tia implements AddsOutput, HandlesArguments, Terminable
         }
 
         foreach ($arguments as $index => $arg) {
+            $arg = (string) $arg; // @phpstan-ignore-line
+
             if ($arg === '') {
                 continue;
             }
diff --git a/tests/.snapshots/success.txt b/tests/.snapshots/success.txt
index e5337bab..0e38f50f 100644
--- a/tests/.snapshots/success.txt
+++ b/tests/.snapshots/success.txt
@@ -1752,6 +1752,10 @@
   ✓ output format → it returns a 32-character hex xxh128 hash
   ✓ output format → it returns a stable hash for empty content
 
+   PASS  Tests\Unit\Plugins\Tia\IsEnabledForRun
+  ✓ does not throw when an integer --random-order-seed is passed as a separate argv element
+  ✓ still detects --tia when an integer argument is present
+
    PASS  Tests\Unit\Preset
   ✓ preset invalid name
   ✓ preset → myFramework
@@ -1937,4 +1941,4 @@
   ✓ pass with dataset with ('my-datas-set-value')
   ✓ within describe → pass with dataset with ('my-datas-set-value')
 
-  Tests:    2 deprecated, 4 warnings, 5 incomplete, 2 notices, 40 todos, 35 skipped, 1328 passed (3008 assertions)
\ No newline at end of file
+  Tests:    2 deprecated, 4 warnings, 5 incomplete, 2 notices, 40 todos, 35 skipped, 1330 passed (3010 assertions)
\ No newline at end of file
diff --git a/tests/Unit/Plugins/Tia/IsEnabledForRun.php b/tests/Unit/Plugins/Tia/IsEnabledForRun.php
new file mode 100644
index 00000000..cbcf6284
--- /dev/null
+++ b/tests/Unit/Plugins/Tia/IsEnabledForRun.php
@@ -0,0 +1,20 @@
+<?php
+
+use Pest\Plugins\Tia;
+
+test('does not throw when an integer --random-order-seed is passed as a separate argv element', function () {
+    // Mirrors the parallel worker argv (see bin/worker.php), where
+    // `--random-order-seed` and its value arrive as separate items and the
+    // seed value is an int rather than a string. Regression test for the
+    // str_starts_with() TypeError in Tia::argumentPresent() — the same class
+    // of bug as #1206, which was only fixed in HandleArguments.
+    $arguments = ['--order-by=random', '--random-order-seed', 1782350398];
+
+    expect(Tia::isEnabledForRun($arguments))->toBeFalse();
+});
+
+test('still detects --tia when an integer argument is present', function () {
+    $arguments = ['--tia', '--random-order-seed', 1782350398];
+
+    expect(Tia::isEnabledForRun($arguments))->toBeTrue();
+});
diff --git a/tests/Visual/Parallel.php b/tests/Visual/Parallel.php
index 72a79090..d497eef3 100644
--- a/tests/Visual/Parallel.php
+++ b/tests/Visual/Parallel.php
@@ -24,13 +24,13 @@ test('parallel', function () use ($run) {
         $file = file_get_contents(__FILE__);
         $file = preg_replace(
             '/\$expected = \'.*?\';/',
-            "\$expected = '2 deprecated, 4 warnings, 5 incomplete, 3 notices, 40 todos, 27 skipped, 1312 passed (2957 assertions)';",
+            "\$expected = '2 deprecated, 4 warnings, 5 incomplete, 3 notices, 40 todos, 27 skipped, 1314 passed (2959 assertions)';",
             $file,
         );
         file_put_contents(__FILE__, $file);
     }
 
-    $expected = '2 deprecated, 4 warnings, 5 incomplete, 3 notices, 40 todos, 27 skipped, 1312 passed (2957 assertions)';
+    $expected = '2 deprecated, 4 warnings, 5 incomplete, 3 notices, 40 todos, 27 skipped, 1314 passed (2959 assertions)';
 
     expect($output)
         ->toContain("Tests:    {$expected}")