fix phpstan issues

This commit is contained in:
danilopolani
2022-03-07 17:51:47 +01:00
parent edd1d890ca
commit a5cbdea868
5 changed files with 9 additions and 7 deletions

View File

@ -23,7 +23,6 @@ final class Covers extends Attribute
/** /**
* Adds attributes regarding the "covers" feature. * Adds attributes regarding the "covers" feature.
* *
* @param \Pest\Factories\TestCaseMethodFactory $method
* @param array<int, string> $attributes * @param array<int, string> $attributes
* *
* @return array<int, string> * @return array<int, string>
@ -38,7 +37,7 @@ final class Covers extends Attribute
} }
$attributes[] = "#[\PHPUnit\Framework\Attributes\CoversClass({$covering->class}::class)]"; $attributes[] = "#[\PHPUnit\Framework\Attributes\CoversClass({$covering->class}::class)]";
} else if ($covering instanceof CoversFunction) { } elseif ($covering instanceof CoversFunction) {
$attributes[] = "#[\PHPUnit\Framework\Attributes\CoversFunction('{$covering->function}')]"; $attributes[] = "#[\PHPUnit\Framework\Attributes\CoversFunction('{$covering->function}')]";
} else { } else {
$attributes[] = "#[\PHPUnit\Framework\Attributes\CoversNothing]"; $attributes[] = "#[\PHPUnit\Framework\Attributes\CoversNothing]";

View File

@ -11,6 +11,5 @@ final class CoversClass
{ {
public function __construct(public string $class) public function __construct(public string $class)
{ {
//
} }
} }

View File

@ -11,6 +11,5 @@ final class CoversFunction
{ {
public function __construct(public string $function) public function __construct(public string $function)
{ {
//
} }
} }

View File

@ -9,5 +9,4 @@ namespace Pest\Factories\Covers;
*/ */
final class CoversNothing final class CoversNothing
{ {
//
} }

View File

@ -4,8 +4,14 @@ use Pest\Factories\Attributes\Covers;
$runCounter = 0; $runCounter = 0;
class TestCoversClass1 {} class TestCoversClass1
class TestCoversClass2 {} {
}
class TestCoversClass2
{
}
it('uses the correct PHPUnit attribute for class', function () { it('uses the correct PHPUnit attribute for class', function () {
$attributes = (new ReflectionClass($this))->getAttributes(); $attributes = (new ReflectionClass($this))->getAttributes();