From 9ec0762d4114b2aaaaf3cd3470b59f623835b87c Mon Sep 17 00:00:00 2001
From: Nuno Maduro <enunomaduro@gmail.com>
Date: Wed, 4 Aug 2021 22:56:18 +0100
Subject: [PATCH] tests: refactors `toBeTruthy` and `toBeFalsy`

---
 tests/.snapshots/success.txt         | 30 +++++++++++++++++++++++++++-
 tests/Features/Expect/ToBeFalsy.php  | 26 ------------------------
 tests/Features/Expect/ToBeTruthy.php | 26 ------------------------
 tests/Features/Expect/toBeFalsy.php  | 19 ++++++++++++++++++
 tests/Features/Expect/toBeTruthy.php | 19 ++++++++++++++++++
 5 files changed, 67 insertions(+), 53 deletions(-)
 delete mode 100644 tests/Features/Expect/ToBeFalsy.php
 delete mode 100644 tests/Features/Expect/ToBeTruthy.php
 create mode 100644 tests/Features/Expect/toBeFalsy.php
 create mode 100644 tests/Features/Expect/toBeTruthy.php

diff --git a/tests/.snapshots/success.txt b/tests/.snapshots/success.txt
index 55b9eaab..a6f69129 100644
--- a/tests/.snapshots/success.txt
+++ b/tests/.snapshots/success.txt
@@ -206,6 +206,20 @@
    PASS  Tests\Features\Expect\toBeFalse
   ✓ strict comparisons
   ✓ failures
+  ✓ not failures
+
+   PASS  Tests\Features\Expect\toBeFalsy
+  ✓ passes as falsy with (false)
+  ✓ passes as falsy with ('')
+  ✓ passes as falsy with (null)
+  ✓ passes as falsy with (0)
+  ✓ passes as falsy with ('0')
+  ✓ passes as not falsy with (true)
+  ✓ passes as not falsy with (1) #1
+  ✓ passes as not falsy with ('false')
+  ✓ passes as not falsy with (1) #2
+  ✓ passes as not falsy with (-1)
+  ✓ failures
   ✓ not failures
 
    PASS  Tests\Features\Expect\toBeFile
@@ -316,6 +330,20 @@
    PASS  Tests\Features\Expect\toBeTrue
   ✓ strict comparisons
   ✓ failures
+  ✓ not failures
+
+   PASS  Tests\Features\Expect\toBeTruthy
+  ✓ passes as truthy with (true)
+  ✓ passes as truthy with (1) #1
+  ✓ passes as truthy with ('false')
+  ✓ passes as truthy with (1) #2
+  ✓ passes as truthy with (-1)
+  ✓ passes as not truthy with (false)
+  ✓ passes as not truthy with ('')
+  ✓ passes as not truthy with (null)
+  ✓ passes as not truthy with (0)
+  ✓ passes as not truthy with ('0')
+  ✓ failures
   ✓ not failures
 
    PASS  Tests\Features\Expect\toBeWritableDirectory
@@ -619,5 +647,5 @@
   ✓ it is a test
   ✓ it uses correct parent class
 
-  Tests:  4 incompleted, 9 skipped, 395 passed
+  Tests:  4 incompleted, 9 skipped, 419 passed
   
\ No newline at end of file
diff --git a/tests/Features/Expect/ToBeFalsy.php b/tests/Features/Expect/ToBeFalsy.php
deleted file mode 100644
index 761e9cc1..00000000
--- a/tests/Features/Expect/ToBeFalsy.php
+++ /dev/null
@@ -1,26 +0,0 @@
-<?php
-
-use PHPUnit\Framework\ExpectationFailedException;
-
-test('passes', function () {
-    expect(false)->toBeFalsy();
-    expect('')->toBeFalsy();
-    expect(null)->toBeFalsy();
-    expect([])->toBeFalsy();
-    expect(0)->toBeFalsy();
-    expect('0')->toBeFalsy();
-
-    expect(true)->not->toBeFalsy();
-    expect([1])->not->toBeFalsy();
-    expect('false')->not->toBeFalsy();
-    expect(1)->not->toBeFalsy();
-    expect(-1)->not->toBeFalsy();
-});
-
-test('failures', function () {
-    expect(1)->toBeFalsy();
-})->throws(ExpectationFailedException::class);
-
-test('not failures', function () {
-    expect(null)->not->toBeFalsy();
-})->throws(ExpectationFailedException::class);
diff --git a/tests/Features/Expect/ToBeTruthy.php b/tests/Features/Expect/ToBeTruthy.php
deleted file mode 100644
index 710bd2df..00000000
--- a/tests/Features/Expect/ToBeTruthy.php
+++ /dev/null
@@ -1,26 +0,0 @@
-<?php
-
-use PHPUnit\Framework\ExpectationFailedException;
-
-test('passes', function () {
-    expect(true)->toBeTruthy();
-    expect([1])->toBeTruthy();
-    expect('false')->toBeTruthy();
-    expect(1)->toBeTruthy();
-    expect(-1)->toBeTruthy();
-
-    expect(false)->not->toBeTruthy();
-    expect('')->not->toBeTruthy();
-    expect(null)->not->toBeTruthy();
-    expect([])->not->toBeTruthy();
-    expect(0)->not->toBeTruthy();
-    expect('0')->not->toBeTruthy();
-});
-
-test('failures', function () {
-    expect(null)->toBeTruthy();
-})->throws(ExpectationFailedException::class);
-
-test('not failures', function () {
-    expect(1)->not->toBeTruthy();
-})->throws(ExpectationFailedException::class);
diff --git a/tests/Features/Expect/toBeFalsy.php b/tests/Features/Expect/toBeFalsy.php
new file mode 100644
index 00000000..d84a68ab
--- /dev/null
+++ b/tests/Features/Expect/toBeFalsy.php
@@ -0,0 +1,19 @@
+<?php
+
+use PHPUnit\Framework\ExpectationFailedException;
+
+test('passes as falsy', function ($value) {
+    expect($value)->toBeFalsy();
+})->with([false, '', null, 0, '0']);
+
+test('passes as not falsy', function ($value) {
+    expect($value)->not->toBeFalsy();
+})->with([true, [1], 'false', 1, -1]);
+
+test('failures', function () {
+    expect(1)->toBeFalsy();
+})->throws(ExpectationFailedException::class);
+
+test('not failures', function () {
+    expect(null)->not->toBeFalsy();
+})->throws(ExpectationFailedException::class);
diff --git a/tests/Features/Expect/toBeTruthy.php b/tests/Features/Expect/toBeTruthy.php
new file mode 100644
index 00000000..c3ea9923
--- /dev/null
+++ b/tests/Features/Expect/toBeTruthy.php
@@ -0,0 +1,19 @@
+<?php
+
+use PHPUnit\Framework\ExpectationFailedException;
+
+test('passes as truthy', function ($value) {
+    expect($value)->toBeTruthy();
+})->with([true, [1], 'false', 1, -1]);
+
+test('passes as not truthy', function ($value) {
+    expect($value)->not->toBeTruthy();
+})->with([false, '', null, 0, '0']);
+
+test('failures', function () {
+    expect(null)->toBeTruthy();
+})->throws(ExpectationFailedException::class);
+
+test('not failures', function () {
+    expect(1)->not->toBeTruthy();
+})->throws(ExpectationFailedException::class);