SADM/pest
1
0
Fork 0
mirror of https://github.com/pestphp/pest.git synced 2026-03-09 17:27:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Merge pull request #919 from WendellAdriel/feature/coverage-errors-only-flag-2"

Browse Source 
This reverts commit 1e2ca40c5b, reversing
changes made to 4522cb5dcb.
This commit is contained in:
Nuno Maduro
2023-12-17 22:03:15 +00:00
parent 1e2ca40c5b
commit 8f738f5d49
3 changed files with 3 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/Plugins/Coverage.php
View File

@ -27,20 +27,6 @@ final class Coverage implements AddsOutput, HandlesArguments
*/
private const MIN_OPTION = 'min';
/**
* @var string
*/
private const ERRORS_ONLY_OPTION = 'errors-only';
/**
* @var string[]
*/
private const ALLOWED_OPTIONS = [
self::COVERAGE_OPTION,
self::MIN_OPTION,
self::ERRORS_ONLY_OPTION,
];
/**
* Whether it should show the coverage or not.
*/
@ -51,11 +37,6 @@ final class Coverage implements AddsOutput, HandlesArguments
*/
public float $coverageMin = 0.0;
/**
* Whether it should show only errors or not.
*/
public bool $errorsOnly = false;
/**
* Creates a new Plugin instance.
*/
@ -70,7 +51,7 @@ final class Coverage implements AddsOutput, HandlesArguments
public function handleArguments(array $originals): array
{
$arguments = [...[''], ...array_values(array_filter($originals, function (string $original): bool {
foreach (self::ALLOWED_OPTIONS as $option) {
foreach ([self::COVERAGE_OPTION, self::MIN_OPTION] as $option) {
if ($original === sprintf('--%s', $option)) {
return true;
}
@ -92,7 +73,6 @@ final class Coverage implements AddsOutput, HandlesArguments
$inputs = [];
$inputs[] = new InputOption(self::COVERAGE_OPTION, null, InputOption::VALUE_NONE);
$inputs[] = new InputOption(self::MIN_OPTION, null, InputOption::VALUE_REQUIRED);
$inputs[] = new InputOption(self::ERRORS_ONLY_OPTION, null, InputOption::VALUE_NONE);
$input = new ArgvInput($arguments, new InputDefinition($inputs));
if ((bool) $input->getOption(self::COVERAGE_OPTION)) {
@ -126,10 +106,6 @@ final class Coverage implements AddsOutput, HandlesArguments
$this->coverageMin = (float) $minOption;
}
if ((bool) $input->getOption(self::ERRORS_ONLY_OPTION)) {
$this->errorsOnly = true;
}
return $originals;
}
@ -146,7 +122,7 @@ final class Coverage implements AddsOutput, HandlesArguments
exit(1);
}
$coverage = \Pest\Support\Coverage::report($this->output, $this->coverageMin, $this->errorsOnly);
$coverage = \Pest\Support\Coverage::report($this->output);
$exitCode = (int) ($coverage < $this->coverageMin);