SADM/pest
1
0
Fork 0
mirror of https://github.com/pestphp/pest.git synced 2026-03-13 03:07:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

remove hardcoded string

Browse Source
This commit is contained in:
Fabio Ivona
2022-09-22 10:56:03 +02:00
parent e34364d8b1
commit 84b8c389b2
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Repositories/DatasetsRepository.php
View File

@ -17,6 +17,8 @@ use Traversable;
*/ */
final class DatasetsRepository final class DatasetsRepository
{ {
private const SEPARATOR = '>>';
/** /**
* Holds the datasets. * Holds the datasets.
* *
@ -38,7 +40,7 @@ final class DatasetsRepository
*/ */
public static function set(string $name, Closure|iterable $data, string $scope): void public static function set(string $name, Closure|iterable $data, string $scope): void
{ {
$datasetKey = "$scope>>>$name"; $datasetKey = "$scope".self::SEPARATOR."$name";
if (array_key_exists("$datasetKey", self::$datasets)) { if (array_key_exists("$datasetKey", self::$datasets)) {
throw new DatasetAlreadyExist($name, $scope); throw new DatasetAlreadyExist($name, $scope);
@ -54,12 +56,12 @@ final class DatasetsRepository
*/ */
public static function with(string $filename, string $description, array $with): void public static function with(string $filename, string $description, array $with): void
{ {
self::$withs["$filename>>>$description"] = $with; self::$withs["$filename".self::SEPARATOR."$description"] = $with;
} }
public static function has(string $filename, string $description): bool public static function has(string $filename, string $description): bool
{ {
return array_key_exists($filename.'>>>'.$description, self::$withs); return array_key_exists($filename.self::SEPARATOR.$description, self::$withs);
} }
/** /**
@ -69,7 +71,7 @@ final class DatasetsRepository
*/ */
public static function get(string $filename, string $description) public static function get(string $filename, string $description)
{ {
$dataset = self::$withs[$filename.'>>>'.$description]; $dataset = self::$withs[$filename.self::SEPARATOR.$description];
$dataset = self::resolve($dataset, $filename); $dataset = self::resolve($dataset, $filename);
@ -140,7 +142,7 @@ final class DatasetsRepository
private static function getScopedDataset(string $name, string $currentTestFile) private static function getScopedDataset(string $name, string $currentTestFile)
{ {
$matchingDatasets = array_filter(self::$datasets, function (string $key) use ($name, $currentTestFile) { $matchingDatasets = array_filter(self::$datasets, function (string $key) use ($name, $currentTestFile) {
[$datasetScope, $datasetName] = explode('>>>', $key); [$datasetScope, $datasetName] = explode(self::SEPARATOR, $key);
if ($name !== $datasetName) { if ($name !== $datasetName) {
return false; return false;