feat(arch): Adds support for opposite expectations of toHavePrefix and toHaveSuffix.

This commit is contained in:
Luke Downing
2023-07-31 11:28:53 +01:00
parent b795a92840
commit 6886558ed1
9 changed files with 96 additions and 7 deletions

View File

@ -42,6 +42,7 @@
"psr-4": { "psr-4": {
"Tests\\Fixtures\\Covers\\": "tests/Fixtures/Covers", "Tests\\Fixtures\\Covers\\": "tests/Fixtures/Covers",
"Tests\\Fixtures\\Inheritance\\": "tests/Fixtures/Inheritance", "Tests\\Fixtures\\Inheritance\\": "tests/Fixtures/Inheritance",
"Tests\\Fixtures\\Arch\\": "tests/Fixtures/Arch",
"Tests\\": "tests/PHPUnit/" "Tests\\": "tests/PHPUnit/"
}, },
"files": [ "files": [

View File

@ -595,12 +595,12 @@ final class Expectation
/** /**
* Asserts that the given expectation target to have the given suffix. * Asserts that the given expectation target to have the given suffix.
*/ */
public function toHavePrefix(string $suffix): ArchExpectation public function toHavePrefix(string $prefix): ArchExpectation
{ {
return Targeted::make( return Targeted::make(
$this, $this,
fn (ObjectDescription $object): bool => str_starts_with($object->reflectionClass->getName(), $suffix), fn (ObjectDescription $object): bool => str_starts_with($object->reflectionClass->getShortName(), $prefix),
"to have prefix '{$suffix}'", "to have prefix '{$prefix}'",
FileLineFinder::where(fn (string $line): bool => str_contains($line, 'class')), FileLineFinder::where(fn (string $line): bool => str_contains($line, 'class')),
); );
} }

View File

@ -291,17 +291,27 @@ final class OppositeExpectation
/** /**
* Not supported. * Not supported.
*/ */
public function toHavePrefix(string $suffix): never public function toHavePrefix(string $prefix): ArchExpectation
{ {
throw InvalidExpectation::fromMethods(['not', 'toHavePrefix']); return Targeted::make(
$this->original,
fn (ObjectDescription $object): bool => ! str_starts_with($object->reflectionClass->getShortName(), $prefix),
"not to have prefix '{$prefix}'",
FileLineFinder::where(fn (string $line): bool => str_contains($line, 'class')),
);
} }
/** /**
* Not supported. * Not supported.
*/ */
public function toHaveSuffix(string $suffix): never public function toHaveSuffix(string $suffix): ArchExpectation
{ {
throw InvalidExpectation::fromMethods(['not', 'toHaveSuffix']); return Targeted::make(
$this->original,
fn (ObjectDescription $object): bool => ! str_ends_with($object->reflectionClass->getName(), $suffix),
"not to have suffix '{$suffix}'",
FileLineFinder::where(fn (string $line): bool => str_contains($line, 'class')),
);
} }
/** /**

View File

@ -0,0 +1,21 @@
<?php
use Pest\Arch\Exceptions\ArchExpectationFailedException;
test('missing prefix')
->throws(ArchExpectationFailedException::class)
->expect('Tests\\Fixtures\\Arch\\ToHavePrefix\\HasNoPrefix')
->toHavePrefix('Prefix');
test('has prefix')
->expect('Tests\\Fixtures\\Arch\\ToHavePrefix\\HasPrefix')
->toHavePrefix('Prefix');
test('opposite missing prefix')
->throws(ArchExpectationFailedException::class)
->expect('Tests\\Fixtures\\Arch\\ToHavePrefix\\HasPrefix')
->not->toHavePrefix('Prefix');
test('opposite has prefix')
->expect('Tests\\Fixtures\\Arch\\ToHavePrefix\\HasNoPrefix')
->not->toHavePrefix('Prefix');

View File

@ -0,0 +1,21 @@
<?php
use Pest\Arch\Exceptions\ArchExpectationFailedException;
test('missing suffix')
->throws(ArchExpectationFailedException::class)
->expect('Tests\\Fixtures\\Arch\\ToHaveSuffix\\HasNoSuffix')
->toHaveSuffix('Suffix');
test('has suffix')
->expect('Tests\\Fixtures\\Arch\\ToHaveSuffix\\HasSuffix')
->toHaveSuffix('Suffix');
test('opposite missing suffix')
->throws(ArchExpectationFailedException::class)
->expect('Tests\\Fixtures\\Arch\\ToHaveSuffix\\HasSuffix')
->not->toHaveSuffix('Suffix');
test('opposite has suffix')
->expect('Tests\\Fixtures\\Arch\\ToHaveSuffix\\HasNoSuffix')
->not->toHaveSuffix('Suffix');

View File

@ -0,0 +1,9 @@
<?php
declare(strict_types=1);
namespace Tests\Fixtures\Arch\ToHavePrefix\HasNoPrefix;
class ClassWithout
{
}

View File

@ -0,0 +1,9 @@
<?php
declare(strict_types=1);
namespace Tests\Fixtures\Arch\ToHavePrefix\HasPrefix;
class PrefixClassWith
{
}

View File

@ -0,0 +1,9 @@
<?php
declare(strict_types=1);
namespace Tests\Fixtures\Arch\ToHaveSuffix\HasNoSuffix;
class ClassWithout
{
}

View File

@ -0,0 +1,9 @@
<?php
declare(strict_types=1);
namespace Tests\Fixtures\Arch\ToHaveSuffix\HasSuffix;
class ClassWithSuffix
{
}