chore: style

tests/Features/Tia/DefaultBranchReplay.php

@@ -4,15 +4,6 @@ declare(strict_types=1);
 
 use Tests\Fixtures\Tia\Project;
 
-/**
- * Reading a baseline recorded on another branch.
- *
- * Without the default-branch fallback, the first `--tia` run on every new branch
- * re-runs a whole suite whose results the default branch already holds — once
- * per branch, forever, on any repository not named `main`.
- *
- * @see https://github.com/pestphp/pest/issues/1823
- */
 afterEach(function (): void {
     Project::destroyAll();
 });
@@ -54,8 +45,6 @@ test('replays on a second new branch too', function (): void {
 
     $result = $project->pest('--tia');
 
-    // The toll is one full run per new branch. It must not come back for the
-    // second branch either.
     expect($result->replayed())->toBe(Project::TOTAL_TESTS, $result->describe())
         ->and($result->uncached())->toBe(0, $result->describe());
 })->skipOnWindows();
@@ -93,12 +82,6 @@ test('replays inside a worktree on a new branch', function (): void {
     $project = Project::make('master');
     $worktree = $project->worktree('feature-worktree');
 
-    // Seeded against the worktree rather than the main checkout: a worktree's
-    // `.git` is a file, so `Storage::originIdentity()` cannot read the remote
-    // from it and the worktree resolves a storage key of its own. That gap is
-    // separate from the branch fallback, and it is the fallback this row is
-    // about — the worktree is checked out on a branch the baseline does not
-    // name, which is the scenario from the issue.
     $project->seedFor($worktree, 'master');
 
     $result = $project->pestIn($worktree, '--tia');

tests/Features/Tia/DefaultBranchResolution.php

@@ -5,17 +5,11 @@ declare(strict_types=1);
 use Symfony\Component\Process\ExecutableFinder;
 use Tests\Fixtures\Tia\Project;
 
-/**
- * How the default branch gets named: declared in `tests/Pest.php`, autodetected
- * from the repository, or not answerable at all.
- */
 afterEach(function (): void {
     Project::destroyAll();
 });
 
 test('a declared default branch beats autodetection', function (): void {
-    // The repository autodetects `develop`, which holds no baseline. Only the
-    // declaration in `tests/Pest.php` can reach the `master` one.
     $project = Project::make('develop', overlay: 'configured-default-branch');
     $project->seed('master');
 
@@ -35,17 +29,12 @@ test('a declared default branch that does not exist degrades to a full run', fun
 
     $result = $project->pest('--tia');
 
-    // Nothing to fall back to, so everything runs — and no baseline is minted
-    // under the name that resolved to nothing.
     expect($result->uncached())->toBe(Project::TOTAL_TESTS, $result->describe())
         ->and($result->exitCode)->toBe(0, $result->describe())
         ->and($project->branchKeys())->toBe(['master', 'feature-x']);
 })->skipOnWindows();
 
 test('the CI provider names the default branch where the checkout cannot', function (): void {
-    // A CI checkout: `actions/checkout` fetches a single ref instead of cloning,
-    // so there is no `origin/HEAD` for git to read the default branch from. The
-    // event payload GitHub hands the job says it outright.
     $project = Project::make('master');
     $project->git()->unsetOriginHead();
     $project->seed('master');
@@ -80,10 +69,6 @@ test('GitLab names the default branch through its own variable', function (): vo
 })->skipOnWindows();
 
 test('a lone recorded baseline names the default branch', function (): void {
-    // Nothing left to ask: no `origin/HEAD`, no CI provider, and an
-    // `init.defaultBranch` that names a branch this repository does not have.
-    // The graph holds exactly one baseline, and it is the only one any branch
-    // could read — so it is the answer.
     $project = Project::make('master');
     $project->git()->unsetOriginHead();
     $project->git()->config('init.defaultBranch', 'main');
@@ -98,9 +83,6 @@ test('a lone recorded baseline names the default branch', function (): void {
 })->skipOnWindows();
 
 test('a default branch nothing can name is refused rather than guessed', function (): void {
-    // Same checkout as above, without the graph that answered it. Guessing here
-    // is what made this bug expensive: the guess reads no baseline at all, and
-    // the output calls that a hit.
     $project = Project::make('master');
     $project->git()->unsetOriginHead();
     $project->git()->config('init.defaultBranch', 'main');
@@ -116,9 +98,6 @@ test('a default branch nothing can name is refused rather than guessed', functio
 })->skipOnWindows();
 
 test('an init.defaultBranch naming a branch that exists is still trusted', function (): void {
-    // The setting is the machine's, not the repository's — worth taking only
-    // where the repository has a branch by that name. It does here, and with no
-    // graph on disk it is the only source left, so the run must not be refused.
     $project = Project::make('master');
     $project->git()->unsetOriginHead();
     $project->git()->config('init.defaultBranch', 'master');
@@ -141,16 +120,11 @@ test('a repository with no remote is refused rather than silently re-run', funct
 
     $result = $project->pest('--tia');
 
-    // Nothing can name the default branch, so every new branch would re-run the
-    // whole suite with no explanation. Saying so beats doing that quietly. The
-    // missing remote is the likeliest reason and gets named as such.
     expect($result->output)->toContain('Tia mode requires a repository with a remote.')
         ->and($result->exitCode)->toBe(1, $result->describe());
 })->skipOnWindows();
 
 test('a remote-less repository holding one baseline is not refused', function (): void {
-    // The refusal above exists to stop a guess, not to demand a remote for its
-    // own sake. With a baseline on disk there is nothing left to guess at.
     $project = Project::make('master');
 
     $project->git()->removeOrigin();
@@ -165,8 +139,6 @@ test('a remote-less repository holding one baseline is not refused', function ()
 })->skipOnWindows();
 
 test('a declared default branch stands in for a missing remote', function (): void {
-    // The escape hatch the refusal above points at: with the branch named by
-    // hand there is nothing left for a remote to answer.
     $project = Project::make('master', overlay: 'configured-default-branch');
 
     $project->git()->removeOrigin();
@@ -185,8 +157,6 @@ test('tia still requires git', function (): void {
 
     $result = $project->pest('--tia');
 
-    // The soft default-branch resolver runs before the branch is named, and it
-    // must not swallow this.
     expect($result->output)->toContain('The feature "Tia mode" requires "git".')
         ->and($result->exitCode)->not->toBe(0);
 })->skipOnWindows();
@@ -212,8 +182,6 @@ test('the default branch is resolved once per run, not once per test', function
 
     expect($git)->not->toBeNull();
 
-    // A `git` first on `PATH` that records what it was asked before handing over
-    // to the real one.
     $log = $project->path('git-calls.log');
     $project->write('shim/git', implode("\n", [
         '#!/bin/sh',

tests/Features/Tia/DefaultBranchWriteTier.php

@@ -4,12 +4,6 @@ declare(strict_types=1);
 
 use Tests\Fixtures\Tia\Project;
 
-/**
- * What the fallback is allowed to touch.
- *
- * Reading another branch's baseline must stay a read: writes belong to the
- * branch that ran, and a branch that has no name of its own must not mint one.
- */
 afterEach(function (): void {
     Project::destroyAll();
 });
@@ -20,8 +14,6 @@ test('narrows to the affected tests on a new branch', function (): void {
 
     $project->git()->switchTo('feature-x', new: true);
 
-    // Semantic, not cosmetic: PHP is hashed at the AST level, so a comment
-    // would not register as a change at all.
     $project->write('app/Calculator.php', <<<'PHP'
         <?php
 
@@ -50,8 +42,6 @@ test('narrows to the affected tests on a new branch', function (): void {
 
     $result = $project->pest('--tia');
 
-    // Two of the three test files cover `Calculator`; the third replays from the
-    // default branch's baseline.
     expect($result->affected())->toBe(4, $result->describe())
         ->and($result->replayed())->toBe(2, $result->describe())
         ->and($result->exitCode)->toBe(0, $result->describe());
@@ -60,18 +50,12 @@ test('narrows to the affected tests on a new branch', function (): void {
 test('filtered mode reads the fallback too', function (): void {
     $project = Project::make('master');
 
-    // A failure cached on the default branch. Filtered mode asks the graph which
-    // test files are due a re-run, and that read has to reach the fallback as
-    // well: without it a new branch sees nothing to do, reports green, and never
-    // re-runs the failure — on every subsequent invocation.
     $project->seed('master', failing: ['adds two numbers']);
 
     $project->git()->switchTo('feature-x', new: true);
 
     $result = $project->pest('--tia', '--filtered');
 
-    // Selection is by file, so the failure's two siblings in `CalculatorTest`
-    // come along; the other two test files stay out of the run entirely.
     expect($result->output)->toContain('from 1 previously unsuccessful test')
         ->and($result->output)->not->toContain('No affected tests found')
         ->and($result->tally())->toContain('2 passed');
@@ -99,8 +83,6 @@ test('a detached HEAD replays without minting a branch key', function (): void {
 
     $result = $project->pest('--tia');
 
-    // A detached HEAD has no branch of its own. The default branch is the
-    // honest key, and no phantom one appears beside it.
     expect($result->replayed())->toBe(Project::TOTAL_TESTS, $result->describe())
         ->and($result->uncached())->toBe(0, $result->describe())
         ->and($project->branchKeys())->toBe(['master']);