From 4c769fac66542c3084a712820c7de8d9f501f96c Mon Sep 17 00:00:00 2001 From: Luke Downing Date: Wed, 22 Mar 2023 10:58:48 +0000 Subject: [PATCH] feat(parallel): Adds support for plugins to filter parallel arguments --- docker/Dockerfile | 2 +- src/Contracts/Plugins/HandlesArguments.php | 2 +- src/Plugins/Parallel.php | 22 ---------------------- 3 files changed, 2 insertions(+), 24 deletions(-) diff --git a/docker/Dockerfile b/docker/Dockerfile index ff10bcb2..f7d37ee8 100644 --- a/docker/Dockerfile +++ b/docker/Dockerfile @@ -2,7 +2,7 @@ ARG PHP=8.1 FROM php:${PHP}-cli-alpine RUN apk update \ - && apk add zip libzip-dev icu-dev + && apk add zip libzip-dev icu-dev git RUN docker-php-ext-configure zip RUN docker-php-ext-install zip diff --git a/src/Contracts/Plugins/HandlesArguments.php b/src/Contracts/Plugins/HandlesArguments.php index 72c9d722..50c3a30e 100644 --- a/src/Contracts/Plugins/HandlesArguments.php +++ b/src/Contracts/Plugins/HandlesArguments.php @@ -10,7 +10,7 @@ namespace Pest\Contracts\Plugins; interface HandlesArguments { /** - * Adds arguments before of the Test Suite execution. + * Adds arguments before the Test Suite execution. * * @param array $arguments * @return array diff --git a/src/Plugins/Parallel.php b/src/Plugins/Parallel.php index 8f53801a..f4992d40 100644 --- a/src/Plugins/Parallel.php +++ b/src/Plugins/Parallel.php @@ -15,9 +15,7 @@ use Pest\Support\Container; use Pest\TestSuite; use function Pest\version; use Symfony\Component\Console\Application; -use Symfony\Component\Console\Command\Command; use Symfony\Component\Console\Input\ArgvInput; -use Symfony\Component\Console\Output\OutputInterface; final class Parallel implements HandlesArguments { @@ -86,12 +84,6 @@ final class Parallel implements HandlesArguments */ private function runTestSuiteInParallel(array $arguments): int { - if (! class_exists(ParaTestCommand::class)) { - $this->askUserToInstallParatest(); - - return Command::FAILURE; - } - $handlers = array_filter( array_map(fn ($handler): object|string => Container::getInstance()->get($handler), self::HANDLERS), fn ($handler): bool => $handler instanceof HandlesArguments, @@ -128,20 +120,6 @@ final class Parallel implements HandlesArguments ); } - /** - * Outputs a message to the user asking them to install ParaTest as a dev dependency. - */ - private function askUserToInstallParatest(): void - { - /** @var OutputInterface $output */ - $output = Container::getInstance()->get(OutputInterface::class); - - $output->writeln([ - 'Pest Parallel requires ParaTest to run.', - 'Please run composer require --dev brianium/paratest.', - ]); - } - /** * Builds an instance of the Paratest command. */