mirror of
https://github.com/pestphp/pest.git
synced 2026-09-05 22:33:35 +02:00
chore: coding style changes
This commit is contained in:
@@ -8,24 +8,12 @@ use Pest\Support\HigherOrderMessageCollection;
|
||||
|
||||
trait HigherOrderable
|
||||
{
|
||||
/**
|
||||
* The higher order messages that are chainable.
|
||||
*/
|
||||
public HigherOrderMessageCollection $chains;
|
||||
|
||||
/**
|
||||
* The higher order messages that are "factory" proxyable.
|
||||
*/
|
||||
public HigherOrderMessageCollection $factoryProxies;
|
||||
|
||||
/**
|
||||
* The higher order messages that are proxyable.
|
||||
*/
|
||||
public HigherOrderMessageCollection $proxies;
|
||||
|
||||
/**
|
||||
* Boot the higher order properties.
|
||||
*/
|
||||
private function bootHigherOrderable(): void
|
||||
{
|
||||
$this->chains = new HigherOrderMessageCollection;
|
||||
|
||||
@@ -30,29 +30,21 @@ final class TestCaseFactory
|
||||
use HigherOrderable;
|
||||
|
||||
/**
|
||||
* The list of attributes.
|
||||
*
|
||||
* @var array<int, Attribute>
|
||||
*/
|
||||
public array $attributes = [];
|
||||
|
||||
/**
|
||||
* The FQN of the Test Case class.
|
||||
*
|
||||
* @var class-string
|
||||
*/
|
||||
public string $class = TestCase::class;
|
||||
|
||||
/**
|
||||
* The list of class methods.
|
||||
*
|
||||
* @var array<string, TestCaseMethodFactory>
|
||||
*/
|
||||
public array $methods = [];
|
||||
|
||||
/**
|
||||
* The list of class traits.
|
||||
*
|
||||
* @var array <int, class-string>
|
||||
*/
|
||||
public array $traits = [
|
||||
@@ -60,14 +52,8 @@ final class TestCaseFactory
|
||||
Concerns\Expectable::class,
|
||||
];
|
||||
|
||||
/**
|
||||
* The namespace for the test case, overrides the path-based namespace when set.
|
||||
*/
|
||||
public ?string $namespace = null;
|
||||
|
||||
/**
|
||||
* Creates a new Factory instance.
|
||||
*/
|
||||
public function __construct(
|
||||
public string $filename
|
||||
) {
|
||||
@@ -84,14 +70,11 @@ final class TestCaseFactory
|
||||
}
|
||||
|
||||
/**
|
||||
* Creates a Test Case class using a runtime evaluate.
|
||||
*
|
||||
* @param array<string, TestCaseMethodFactory> $methods
|
||||
*/
|
||||
public function evaluate(string $filename, array $methods): void
|
||||
{
|
||||
if ('\\' === DIRECTORY_SEPARATOR) {
|
||||
// In case Windows, strtolower drive name, like in UsesCall.
|
||||
$filename = (string) preg_replace_callback('~^(?P<drive>[a-z]+:\\\)~i', static fn (array $match): string => strtolower($match['drive']), $filename);
|
||||
}
|
||||
|
||||
@@ -114,11 +97,8 @@ final class TestCaseFactory
|
||||
|
||||
$relativePath = str_replace(DIRECTORY_SEPARATOR, '\\', $relativePath);
|
||||
|
||||
// Strip out any %-encoded octets.
|
||||
$relativePath = (string) preg_replace('|%[a-fA-F0-9][a-fA-F0-9]|', '', $relativePath);
|
||||
// Remove escaped quote sequences (maintain namespace)
|
||||
$relativePath = str_replace(array_map(fn (string $quote): string => sprintf('\\%s', $quote), ['\'', '"']), '', $relativePath);
|
||||
// Limit to Unicode letters and numbers.
|
||||
$relativePath = (string) preg_replace('/[^\p{L}\p{N}\\\\]/u', '', $relativePath);
|
||||
|
||||
$classFQN = 'P\\'.$relativePath;
|
||||
@@ -197,9 +177,6 @@ final class TestCaseFactory
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Adds the given Method to the Test Case.
|
||||
*/
|
||||
public function addMethod(TestCaseMethodFactory $method): void
|
||||
{
|
||||
if ($method->description === null) {
|
||||
@@ -233,9 +210,6 @@ final class TestCaseFactory
|
||||
$this->methods[$method->description] = $method;
|
||||
}
|
||||
|
||||
/**
|
||||
* Checks if a test case has a method.
|
||||
*/
|
||||
public function hasMethod(string $methodName): bool
|
||||
{
|
||||
foreach ($this->methods as $method) {
|
||||
@@ -251,9 +225,6 @@ final class TestCaseFactory
|
||||
return false;
|
||||
}
|
||||
|
||||
/**
|
||||
* Gets a Method by the given name.
|
||||
*/
|
||||
public function getMethod(string $methodName): TestCaseMethodFactory
|
||||
{
|
||||
foreach ($this->methods as $method) {
|
||||
|
||||
@@ -27,84 +27,54 @@ final class TestCaseMethodFactory
|
||||
use HigherOrderable;
|
||||
|
||||
/**
|
||||
* The list of attributes.
|
||||
*
|
||||
* @var array<int, Attribute>
|
||||
*/
|
||||
public array $attributes = [];
|
||||
|
||||
/**
|
||||
* The test's describing, if any.
|
||||
*
|
||||
* @var array<int, Description>
|
||||
*/
|
||||
public array $describing = [];
|
||||
|
||||
/**
|
||||
* The test's description, if any.
|
||||
*/
|
||||
public ?string $description = null;
|
||||
|
||||
/**
|
||||
* The test's number of repetitions.
|
||||
*/
|
||||
public int $repetitions = 1;
|
||||
|
||||
/**
|
||||
* The test's number of flaky retry tries.
|
||||
*/
|
||||
public ?int $flakyTries = null;
|
||||
|
||||
/**
|
||||
* Determines if the test is a "todo".
|
||||
*/
|
||||
public bool $todo = false;
|
||||
|
||||
/**
|
||||
* The associated issue numbers.
|
||||
*
|
||||
* @var array<int, int>
|
||||
*/
|
||||
public array $issues = [];
|
||||
|
||||
/**
|
||||
* The test assignees.
|
||||
*
|
||||
* @var array<int, string>
|
||||
*/
|
||||
public array $assignees = [];
|
||||
|
||||
/**
|
||||
* The associated PRs numbers.
|
||||
*
|
||||
* @var array<int, int>
|
||||
*/
|
||||
public array $prs = [];
|
||||
|
||||
/**
|
||||
* The test's notes.
|
||||
*
|
||||
* @var array<int, string>
|
||||
*/
|
||||
public array $notes = [];
|
||||
|
||||
/**
|
||||
* The test's datasets.
|
||||
*
|
||||
* @var array<Closure|iterable<int|string, mixed>|string>
|
||||
*/
|
||||
public array $datasets = [];
|
||||
|
||||
/**
|
||||
* The test's dependencies.
|
||||
*
|
||||
* @var array<int, string>
|
||||
*/
|
||||
public array $depends = [];
|
||||
|
||||
/**
|
||||
* The test's groups.
|
||||
*
|
||||
* @var array<int, string>
|
||||
*/
|
||||
public array $groups = [];
|
||||
@@ -114,9 +84,6 @@ final class TestCaseMethodFactory
|
||||
*/
|
||||
public bool $__ran = false;
|
||||
|
||||
/**
|
||||
* Creates a new test case method factory instance.
|
||||
*/
|
||||
public function __construct(
|
||||
public string $filename,
|
||||
public ?Closure $closure,
|
||||
@@ -128,9 +95,6 @@ final class TestCaseMethodFactory
|
||||
$this->bootHigherOrderable();
|
||||
}
|
||||
|
||||
/**
|
||||
* Sets the test's hooks, and runs any proxy to the test case.
|
||||
*/
|
||||
public function setUp(TestCase $concrete): void
|
||||
{
|
||||
$concrete::flush(); // @phpstan-ignore-line
|
||||
@@ -146,17 +110,11 @@ final class TestCaseMethodFactory
|
||||
$this->factoryProxies->proxy($concrete);
|
||||
}
|
||||
|
||||
/**
|
||||
* Flushes the test case.
|
||||
*/
|
||||
public function tearDown(TestCase $concrete): void
|
||||
{
|
||||
$concrete::flush(); // @phpstan-ignore-line
|
||||
}
|
||||
|
||||
/**
|
||||
* Creates the test's closure.
|
||||
*/
|
||||
public function getClosure(): Closure
|
||||
{
|
||||
$closure = $this->closure;
|
||||
@@ -178,17 +136,11 @@ final class TestCaseMethodFactory
|
||||
};
|
||||
}
|
||||
|
||||
/**
|
||||
* Determine if the test case will receive argument input from Pest, or not.
|
||||
*/
|
||||
public function receivesArguments(): bool
|
||||
{
|
||||
return $this->datasets !== [] || $this->depends !== [] || $this->repetitions > 1;
|
||||
}
|
||||
|
||||
/**
|
||||
* Creates a PHPUnit method as a string ready for evaluation.
|
||||
*/
|
||||
public function buildForEvaluation(): string
|
||||
{
|
||||
if ($this->description === null) {
|
||||
@@ -248,9 +200,6 @@ final class TestCaseMethodFactory
|
||||
PHP;
|
||||
}
|
||||
|
||||
/**
|
||||
* Creates a PHPUnit Data Provider as a string ready for evaluation.
|
||||
*/
|
||||
private function buildDatasetForEvaluation(string $methodName, string $dataProviderName): string
|
||||
{
|
||||
$datasets = $this->datasets;
|
||||
|
||||
Reference in New Issue
Block a user