SADM/pest
1
0
Fork 0
mirror of https://github.com/pestphp/pest.git synced 2026-03-11 02:07:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(container): resolves dependencies without contructor

Browse Source 
Co-Authored-By: Johannes Pichler <fetzi@users.noreply.github.com>
This commit is contained in:
Nuno Maduro
2020-06-14 16:15:05 +02:00
parent c79c0feec8
commit 3a78aaef8f
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Support/Container.php
View File

@ -92,6 +92,8 @@ final class Container
return $reflectionClass->newInstanceArgs($params); return $reflectionClass->newInstanceArgs($params);
} }
return $reflectionClass->newInstance();
} }
throw ShouldNotHappen::fromMessage(sprintf('A dependency with the name `%s` cannot be resolved.', $id)); throw ShouldNotHappen::fromMessage(sprintf('A dependency with the name `%s` cannot be resolved.', $id));

12
tests/Unit/Support/Container.php
View File

@ -18,6 +18,10 @@ it('gets an instance', function () {
assertSame($this->container, $this->container->get(Container::class)); assertSame($this->container, $this->container->get(Container::class));
}); });
test('autowire', function () {
assertInstanceOf(Container::class, $this->container->get(Container::class));
});
it('creates an instance and resolves parameters', function () { it('creates an instance and resolves parameters', function () {
$this->container->add(Container::class, $this->container); $this->container->add(Container::class, $this->container);
$instance = $this->container->get(ClassWithDependency::class); $instance = $this->container->get(ClassWithDependency::class);
@ -39,15 +43,9 @@ it('can resolve builtin value types', function () {
assertInstanceOf(TestSuite::class, $instance); assertInstanceOf(TestSuite::class, $instance);
}); });
it('cannot resolve a parameter that requires additional dependencies', function () {
$this->expectException(ShouldNotHappen::class);
$this->container->get(ClassWithDependency::class);
});
it('cannot resolve a parameter without type', function () { it('cannot resolve a parameter without type', function () {
$this->expectException(ShouldNotHappen::class);
$this->container->get(ClassWithoutTypeParameter::class); $this->container->get(ClassWithoutTypeParameter::class);
}); })->throws(ShouldNotHappen::class);
class ClassWithDependency class ClassWithDependency
{ {