From 348bd4b923f31cfddfc90a60f2a432e36bc0300d Mon Sep 17 00:00:00 2001
From: Nuno Maduro <enunomaduro@gmail.com>
Date: Wed, 9 Nov 2022 20:31:35 +0000
Subject: [PATCH] feat: improves feedback when test misses description

---
 src/Exceptions/TestDescriptionMissing.php | 24 +++++++++++++++++++++++
 src/Factories/TestCaseFactory.php         |  3 ++-
 2 files changed, 26 insertions(+), 1 deletion(-)
 create mode 100644 src/Exceptions/TestDescriptionMissing.php

diff --git a/src/Exceptions/TestDescriptionMissing.php b/src/Exceptions/TestDescriptionMissing.php
new file mode 100644
index 00000000..67f75930
--- /dev/null
+++ b/src/Exceptions/TestDescriptionMissing.php
@@ -0,0 +1,24 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Pest\Exceptions;
+
+use InvalidArgumentException;
+use NunoMaduro\Collision\Contracts\RenderlessEditor;
+use NunoMaduro\Collision\Contracts\RenderlessTrace;
+use Symfony\Component\Console\Exception\ExceptionInterface;
+
+/**
+ * @internal
+ */
+final class TestDescriptionMissing extends InvalidArgumentException implements ExceptionInterface, RenderlessEditor, RenderlessTrace
+{
+    /**
+     * Creates a new Exception instance.
+     */
+    public function __construct(string $fileName)
+    {
+        parent::__construct(sprintf('Test misses description in the filename `%s`.', $fileName));
+    }
+}
diff --git a/src/Factories/TestCaseFactory.php b/src/Factories/TestCaseFactory.php
index ee4daf84..a2b32548 100644
--- a/src/Factories/TestCaseFactory.php
+++ b/src/Factories/TestCaseFactory.php
@@ -8,6 +8,7 @@ use ParseError;
 use Pest\Concerns;
 use Pest\Contracts\HasPrintableTestCaseName;
 use Pest\Exceptions\DatasetMissing;
+use Pest\Exceptions\TestDescriptionMissing;
 use Pest\Exceptions\ShouldNotHappen;
 use Pest\Exceptions\TestAlreadyExist;
 use Pest\Factories\Concerns\HigherOrderable;
@@ -224,7 +225,7 @@ final class TestCaseFactory
     public function addMethod(TestCaseMethodFactory $method): void
     {
         if ($method->description === null) {
-            throw ShouldNotHappen::fromMessage('The test description may not be empty.');
+            throw new TestDescriptionMissing($method->filename);
         }
 
         if (array_key_exists($method->description, $this->methods)) {