cleanup for self-review

src/Factories/TestCaseFactory.php

@@ -179,7 +179,7 @@ final class TestCaseFactory
 
         // Strip out any %-encoded octets.
         $relativePath = (string) preg_replace('|%[a-fA-F0-9][a-fA-F0-9]|', '', $relativePath);
-        // Remove escaped quote sequences
+        // Remove escaped quote sequences (maintain namespace)
         $relativePath = str_replace(array_map(function (string $quote): string {
             return sprintf('\\%s', $quote);
         }, ['\'', '"']), '', $relativePath);

tests/.snapshots/success.txt

@@ -104,25 +104,25 @@
   ✓ it example 2
 
    PASS  Tests\PHPUnit\CustomAffixes\InvalidTestName
-  ✓ this runs file names like "@#$%^&()-_=+.php"
+  ✓ it runs file names like `@#$%^&()-_=+.php`
 
    PASS  Tests\PHPUnit\CustomAffixes\ATestWithSpaces
-  ✓ this runs file names like "A Test With Spaces.php"
+  ✓ it runs file names like `A Test With Spaces.php`
 
    PASS  Tests\PHPUnit\CustomAffixes\AdditionalFileExtensionspec
-  ✓ this runs file names like "AdditionalFileExtension.spec.php"
+  ✓ it runs file names like `AdditionalFileExtension.spec.php`
 
    PASS  Tests\PHPUnit\CustomAffixes\ManyExtensionsclasstest
-  ✓ this runs file names like "ManyExtensions.class.test.php"
+  ✓ it runs file names like `ManyExtensions.class.test.php`
 
    PASS  Tests\PHPUnit\CustomAffixes\TestCaseWithQuotes
-  ✓ this runs file names like "Test 'Case' With Quotes.php"
+  ✓ it runs file names like `Test 'Case' With Quotes.php`
 
    PASS  Tests\PHPUnit\CustomAffixes\kebabcasespec
-  ✓ this runs file names like "kebab-case-spec.php"
+  ✓ it runs file names like `kebab-case-spec.php`
 
    PASS  Tests\PHPUnit\CustomAffixes\snakecasespec
-  ✓ this runs file names like "snake_case_spec.php"
+  ✓ it runs file names like `snake_case_spec.php`
 
    PASS  Tests\PHPUnit\CustomTestCase\UsesPerDirectory
   ✓ closure was bound to CustomTestCase

tests/PHPUnit/CustomAffixes/@#$%^&()-_=+.php

@@ -1,6 +1,10 @@
 <?php
 
-test(sprintf('this runs file names like "%s"', basename(__FILE__)))
-    ->assertTrue(true);
+/*
+ * NOTE: To preserve cross-platform testing compatibility we cannot use ! * and
+ * other Windows reserved characters in this test's filename.
+ *
+ * See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#naming-conventions
+ */
 
-    //!@#$%^&*()-_=+
+it(sprintf('runs file names like `%s`', basename(__FILE__)))->assertTrue(true);

tests/PHPUnit/CustomAffixes/A Test With Spaces.php

@@ -1,4 +1,3 @@
 <?php
 
-test(sprintf('this runs file names like "%s"', basename(__FILE__)))
-    ->assertTrue(true);
+it(sprintf('runs file names like `%s`', basename(__FILE__)))->assertTrue(true);

tests/PHPUnit/CustomAffixes/AdditionalFileExtension.spec.php

@@ -1,4 +1,3 @@
 <?php
 
-test(sprintf('this runs file names like "%s"', basename(__FILE__)))
-    ->assertTrue(true);
+it(sprintf('runs file names like `%s`', basename(__FILE__)))->assertTrue(true);

tests/PHPUnit/CustomAffixes/ManyExtensions.class.test.php

@@ -1,4 +1,3 @@
 <?php
 
-test(sprintf('this runs file names like "%s"', basename(__FILE__)))
-    ->assertTrue(true);
+it(sprintf('runs file names like `%s`', basename(__FILE__)))->assertTrue(true);

tests/PHPUnit/CustomAffixes/Test 'Case' With Quotes.php

@@ -1,4 +1,3 @@
 <?php
 
-test(sprintf('this runs file names like "%s"', basename(__FILE__)))
-    ->assertTrue(true);
+it(sprintf('runs file names like `%s`', basename(__FILE__)))->assertTrue(true);

tests/PHPUnit/CustomAffixes/kebab-case-spec.php

@@ -1,4 +1,3 @@
 <?php
 
-test(sprintf('this runs file names like "%s"', basename(__FILE__)))
-    ->assertTrue(true);
+it(sprintf('runs file names like `%s`', basename(__FILE__)))->assertTrue(true);

tests/PHPUnit/CustomAffixes/snake_case_spec.php

@@ -1,4 +1,3 @@
 <?php
 
-test(sprintf('this runs file names like "%s"', basename(__FILE__)))
-    ->assertTrue(true);
+it(sprintf('runs file names like `%s`', basename(__FILE__)))->assertTrue(true);