cleanup for self-review

This commit is contained in:
jordanbrauer
2021-02-13 13:31:25 -06:00
parent 9a0240bc7b
commit 19a1569fa8
9 changed files with 21 additions and 23 deletions

View File

@ -179,7 +179,7 @@ final class TestCaseFactory
// Strip out any %-encoded octets. // Strip out any %-encoded octets.
$relativePath = (string) preg_replace('|%[a-fA-F0-9][a-fA-F0-9]|', '', $relativePath); $relativePath = (string) preg_replace('|%[a-fA-F0-9][a-fA-F0-9]|', '', $relativePath);
// Remove escaped quote sequences // Remove escaped quote sequences (maintain namespace)
$relativePath = str_replace(array_map(function (string $quote): string { $relativePath = str_replace(array_map(function (string $quote): string {
return sprintf('\\%s', $quote); return sprintf('\\%s', $quote);
}, ['\'', '"']), '', $relativePath); }, ['\'', '"']), '', $relativePath);

View File

@ -104,25 +104,25 @@
✓ it example 2 ✓ it example 2
PASS Tests\PHPUnit\CustomAffixes\InvalidTestName PASS Tests\PHPUnit\CustomAffixes\InvalidTestName
✓ this runs file names like "@#$%^&()-_=+.php" it runs file names like `@#$%^&()-_=+.php`
PASS Tests\PHPUnit\CustomAffixes\ATestWithSpaces PASS Tests\PHPUnit\CustomAffixes\ATestWithSpaces
✓ this runs file names like "A Test With Spaces.php" it runs file names like `A Test With Spaces.php`
PASS Tests\PHPUnit\CustomAffixes\AdditionalFileExtensionspec PASS Tests\PHPUnit\CustomAffixes\AdditionalFileExtensionspec
✓ this runs file names like "AdditionalFileExtension.spec.php" it runs file names like `AdditionalFileExtension.spec.php`
PASS Tests\PHPUnit\CustomAffixes\ManyExtensionsclasstest PASS Tests\PHPUnit\CustomAffixes\ManyExtensionsclasstest
✓ this runs file names like "ManyExtensions.class.test.php" it runs file names like `ManyExtensions.class.test.php`
PASS Tests\PHPUnit\CustomAffixes\TestCaseWithQuotes PASS Tests\PHPUnit\CustomAffixes\TestCaseWithQuotes
✓ this runs file names like "Test 'Case' With Quotes.php" it runs file names like `Test 'Case' With Quotes.php`
PASS Tests\PHPUnit\CustomAffixes\kebabcasespec PASS Tests\PHPUnit\CustomAffixes\kebabcasespec
✓ this runs file names like "kebab-case-spec.php" it runs file names like `kebab-case-spec.php`
PASS Tests\PHPUnit\CustomAffixes\snakecasespec PASS Tests\PHPUnit\CustomAffixes\snakecasespec
✓ this runs file names like "snake_case_spec.php" it runs file names like `snake_case_spec.php`
PASS Tests\PHPUnit\CustomTestCase\UsesPerDirectory PASS Tests\PHPUnit\CustomTestCase\UsesPerDirectory
✓ closure was bound to CustomTestCase ✓ closure was bound to CustomTestCase

View File

@ -1,6 +1,10 @@
<?php <?php
test(sprintf('this runs file names like "%s"', basename(__FILE__))) /*
->assertTrue(true); * NOTE: To preserve cross-platform testing compatibility we cannot use ! * and
* other Windows reserved characters in this test's filename.
*
* See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#naming-conventions
*/
//!@#$%^&*()-_=+ it(sprintf('runs file names like `%s`', basename(__FILE__)))->assertTrue(true);

View File

@ -1,4 +1,3 @@
<?php <?php
test(sprintf('this runs file names like "%s"', basename(__FILE__))) it(sprintf('runs file names like `%s`', basename(__FILE__)))->assertTrue(true);
->assertTrue(true);

View File

@ -1,4 +1,3 @@
<?php <?php
test(sprintf('this runs file names like "%s"', basename(__FILE__))) it(sprintf('runs file names like `%s`', basename(__FILE__)))->assertTrue(true);
->assertTrue(true);

View File

@ -1,4 +1,3 @@
<?php <?php
test(sprintf('this runs file names like "%s"', basename(__FILE__))) it(sprintf('runs file names like `%s`', basename(__FILE__)))->assertTrue(true);
->assertTrue(true);

View File

@ -1,4 +1,3 @@
<?php <?php
test(sprintf('this runs file names like "%s"', basename(__FILE__))) it(sprintf('runs file names like `%s`', basename(__FILE__)))->assertTrue(true);
->assertTrue(true);

View File

@ -1,4 +1,3 @@
<?php <?php
test(sprintf('this runs file names like "%s"', basename(__FILE__))) it(sprintf('runs file names like `%s`', basename(__FILE__)))->assertTrue(true);
->assertTrue(true);

View File

@ -1,4 +1,3 @@
<?php <?php
test(sprintf('this runs file names like "%s"', basename(__FILE__))) it(sprintf('runs file names like `%s`', basename(__FILE__)))->assertTrue(true);
->assertTrue(true);