SADM/pest
1
0
Fork 0
mirror of https://github.com/pestphp/pest.git synced 2026-03-10 17:57:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

chore: phpstan level 5

Browse Source
This commit is contained in:
Nuno Maduro
2021-11-14 21:23:02 +00:00
parent 8ace01b6f1
commit 183f975166
23 changed files with 65 additions and 796 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Support/ChainableClosure.php
View File

@ -5,6 +5,8 @@ declare(strict_types=1);
namespace Pest\Support;
use Closure;
use Pest\Exceptions\ShouldNotHappen;
use PHPUnit\Framework\TestCase;
/**
* @internal
@ -17,9 +19,11 @@ final class ChainableClosure
public static function from(Closure $closure, Closure $next): Closure
{
return function () use ($closure, $next): void {
/* @phpstan-ignore-next-line */
if (! is_object($this)) { // @phpstan-ignore-line
throw ShouldNotHappen::fromMessage('$this not bound to chainable closure.');
}
call_user_func_array(Closure::bind($closure, $this, $this::class), func_get_args());
/* @phpstan-ignore-next-line */
call_user_func_array(Closure::bind($next, $this, $this::class), func_get_args());
};
}
@ -30,9 +34,7 @@ final class ChainableClosure
public static function fromStatic(Closure $closure, Closure $next): Closure
{
return static function () use ($closure, $next): void {
/* @phpstan-ignore-next-line */
call_user_func_array(Closure::bind($closure, null, self::class), func_get_args());
/* @phpstan-ignore-next-line */
call_user_func_array(Closure::bind($next, null, self::class), func_get_args());
};
}

1
src/Support/Container.php
View File

@ -63,7 +63,6 @@ final class Container
*/
private function build(string $id): object
{
/** @phpstan-ignore-next-line */
$reflectionClass = new ReflectionClass($id);
if ($reflectionClass->isInstantiable()) {

2
src/Support/HigherOrderCallables.php
View File

@ -25,7 +25,7 @@ final class HigherOrderCallables
*
* Create a new expectation. Callable values will be executed prior to returning the new expectation.
*
* @param callable|TValue $value
* @param (callable():TValue)|TValue $value
*
* @return Expectation<TValue>
*/

7
src/Support/HigherOrderMessage.php
View File

@ -18,14 +18,14 @@ final class HigherOrderMessage
/**
* An optional condition that will determine if the message will be executed.
*
* @var (callable(): bool)|null
* @var (Closure(): bool)|null
*/
public $condition;
public ?Closure $condition = null;
/**
* Creates a new higher order message.
*
* @param array<int, mixed>|null $arguments
* @param array<int, mixed> $arguments
*/
public function __construct(
public string $filename,
@ -41,7 +41,6 @@ final class HigherOrderMessage
*/
public function call(object $target): mixed
{
/* @phpstan-ignore-next-line */
if (is_callable($this->condition) && call_user_func(Closure::bind($this->condition, $target)) === false) {
return $target;
}

4
src/Support/HigherOrderMessageCollection.php
View File

@ -19,7 +19,7 @@ final class HigherOrderMessageCollection
*
* @param array<int, mixed>|null $arguments
*/
public function add(string $filename, int $line, string $name, array $arguments = null): void
public function add(string $filename, int $line, string $name, ?array $arguments): void
{
$this->messages[] = new HigherOrderMessage($filename, $line, $name, $arguments);
}
@ -29,7 +29,7 @@ final class HigherOrderMessageCollection
*
* @param array<int, mixed>|null $arguments
*/
public function addWhen(callable $condition, string $filename, int $line, string $name, array $arguments = null): void
public function addWhen(callable $condition, string $filename, int $line, string $name, ?array $arguments): void
{
$this->messages[] = (new HigherOrderMessage($filename, $line, $name, $arguments))->when($condition);
}

7
src/Support/HigherOrderTapProxy.php
View File

@ -31,8 +31,7 @@ final class HigherOrderTapProxy
*/
public function __set(string $property, $value): void
{
// @phpstan-ignore-next-line
$this->target->{$property} = $value;
$this->target->{$property} = $value; // @phpstan-ignore-line
}
/**
@ -43,8 +42,8 @@ final class HigherOrderTapProxy
public function __get(string $property)
{
try {
// @phpstan-ignore-next-line
return $this->target->{$property};
/** @throws Throwable */
return $this->target->{$property}; // @phpstan-ignore-line
} catch (Throwable $throwable) {
Reflection::setPropertyValue($throwable, 'file', Backtrace::file());
Reflection::setPropertyValue($throwable, 'line', Backtrace::line());