SADM/pest
1
0
Fork 0
mirror of https://github.com/pestphp/pest.git synced 2026-03-06 15:57:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Merge pull request #413 from def-studio/fix_skipping_tests_with_exception_asserting"

Browse Source 
This reverts commit e853792a59, reversing
changes made to 205238fcbf.
This commit is contained in:
Nuno Maduro
2021-10-10 14:40:07 +01:00
parent e853792a59
commit 04dcebf3aa
2 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Factories/TestCaseFactory.php
View File

@ -144,8 +144,8 @@ final class TestCaseFactory
* @return mixed * @return mixed
*/ */
$test = function () use ($chains, $proxies, $factoryTest) { $test = function () use ($chains, $proxies, $factoryTest) {
$chains->chain($this);
$proxies->proxy($this); $proxies->proxy($this);
$chains->chain($this);
/* @phpstan-ignore-next-line */ /* @phpstan-ignore-next-line */
return call_user_func(Closure::bind($factoryTest, $this, get_class($this)), ...func_get_args()); return call_user_func(Closure::bind($factoryTest, $this, get_class($this)), ...func_get_args());

6
tests/Features/Exceptions.php
View File

@ -1,7 +1,5 @@
<?php <?php
use PHPUnit\Framework\ExpectationFailedException;
it('gives access the the underlying expectException', function () { it('gives access the the underlying expectException', function () {
$this->expectException(InvalidArgumentException::class); $this->expectException(InvalidArgumentException::class);
@ -39,7 +37,3 @@ it('can just define the message if given condition is true', function () {
it('can just define the message if given condition is 1', function () { it('can just define the message if given condition is 1', function () {
throw new Exception('Something bad happened'); throw new Exception('Something bad happened');
})->throwsIf(1, 'Something bad happened'); })->throwsIf(1, 'Something bad happened');
it('can handle a skipped test if it is trying to catch an exception', function () {
expect(1)->toBe(2);
})->throws(ExpectationFailedException::class)->skip('this test should be skipped')->only();