SADM/pest
1
0
Fork 0
mirror of https://github.com/pestphp/pest.git synced 2026-09-05 22:33:35 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: key Tia results per dataset row (#1799)

Browse Source 
The result cache was keyed `Class::method` on both sides, so every row of a
`->with()` test shared one entry and the last writer won. On replay that single
status was handed to every row.

`TestMethod::id()` already appends `#dataSetName`, and `TestCase` reaches the
same value object through `valueObjectForEvents()`, so both sides can use it.
This commit is contained in:
Jeffrey van Hees
2026-08-03 03:43:15 +02:00
committed by GitHub
parent b63626a94d
commit 047753c836
4 changed files with 118 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Concerns/Testable.php
+2 -2
View File
@@ -280,7 +280,7 @@ trait Testable
/** @var Tia $tia */
$tia = Container::getInstance()->get(Tia::class);
$status = $tia->getStatus(self::$__filename, $this::class.'::'.$this->name());
$status = $tia->getStatus(self::$__filename, $this->valueObjectForEvents()->id());
$replay = ReplayType::fromStatus($status);
if ($replay !== ReplayType::None) {
@@ -319,7 +319,7 @@ trait Testable
private function __beginReplay(ReplayType $replay, Tia $tia): void
{
$this->__replay = $replay;
$this->__replayAssertions = $tia->getAssertionCount($this::class.'::'.$this->name());
$this->__replayAssertions = $tia->getAssertionCount($this->valueObjectForEvents()->id());
$this->__ran = true;
}