mirror of
https://github.com/pestphp/pest.git
synced 2026-03-11 10:17:23 +01:00
add generic covers method to accept both classes and functions
This commit is contained in:
@ -5,6 +5,7 @@ declare(strict_types=1);
|
|||||||
namespace Pest\PendingCalls;
|
namespace Pest\PendingCalls;
|
||||||
|
|
||||||
use Closure;
|
use Closure;
|
||||||
|
use InvalidArgumentException;
|
||||||
use Pest\Factories\Covers\CoversClass;
|
use Pest\Factories\Covers\CoversClass;
|
||||||
use Pest\Factories\Covers\CoversFunction;
|
use Pest\Factories\Covers\CoversFunction;
|
||||||
use Pest\Factories\Covers\CoversNothing;
|
use Pest\Factories\Covers\CoversNothing;
|
||||||
@ -171,6 +172,31 @@ final class TestCall
|
|||||||
return $this;
|
return $this;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Sets the covered classes or methods.
|
||||||
|
*/
|
||||||
|
public function covers(string ...$classesOrFunctions): TestCall
|
||||||
|
{
|
||||||
|
foreach ($classesOrFunctions as $classOrFunction) {
|
||||||
|
$isClass = class_exists($classOrFunction);
|
||||||
|
$isMethod = function_exists($classOrFunction);
|
||||||
|
|
||||||
|
if (!$isClass && !$isMethod) {
|
||||||
|
throw new InvalidArgumentException(
|
||||||
|
sprintf('No class or method named "%s" has been found.', $classOrFunction)
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
if ($isClass) {
|
||||||
|
$this->coversClass($classOrFunction);
|
||||||
|
} else {
|
||||||
|
$this->coversFunction($classOrFunction);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return $this;
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Sets the covered classes.
|
* Sets the covered classes.
|
||||||
*/
|
*/
|
||||||
|
|||||||
@ -1,18 +1,24 @@
|
|||||||
<?php
|
<?php
|
||||||
|
|
||||||
use Pest\Factories\Attributes\Covers;
|
use Pest\Factories\Attributes\Covers;
|
||||||
|
use Pest\PendingCalls\TestCall;
|
||||||
|
use Pest\TestSuite;
|
||||||
|
|
||||||
$runCounter = 0;
|
$runCounter = 0;
|
||||||
|
|
||||||
class TestCoversClass1
|
class TestCoversClass1
|
||||||
{
|
{
|
||||||
|
|
||||||
}
|
}
|
||||||
class TestCoversClass2
|
class TestCoversClass2
|
||||||
{
|
{
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
class TestCoversClass3
|
||||||
|
{
|
||||||
|
}
|
||||||
|
|
||||||
|
function testCoversFunction() { }
|
||||||
|
|
||||||
it('uses the correct PHPUnit attribute for class', function () {
|
it('uses the correct PHPUnit attribute for class', function () {
|
||||||
$attributes = (new ReflectionClass($this))->getAttributes();
|
$attributes = (new ReflectionClass($this))->getAttributes();
|
||||||
|
|
||||||
@ -36,8 +42,6 @@ it('uses the correct PHPUnit attribute for nothing', function () {
|
|||||||
it('removes duplicated attributes', function () {
|
it('removes duplicated attributes', function () {
|
||||||
$attributes = (new ReflectionClass($this))->getAttributes();
|
$attributes = (new ReflectionClass($this))->getAttributes();
|
||||||
|
|
||||||
expect($attributes)->toHaveCount(7); // 3 classes, 3 functions, 1 nothing
|
|
||||||
|
|
||||||
expect($attributes[3]->getName())->toBe('PHPUnit\Framework\Attributes\CoversClass');
|
expect($attributes[3]->getName())->toBe('PHPUnit\Framework\Attributes\CoversClass');
|
||||||
expect($attributes[3]->getArguments()[0])->toBe('P\Tests\Features\TestCoversClass2');
|
expect($attributes[3]->getArguments()[0])->toBe('P\Tests\Features\TestCoversClass2');
|
||||||
expect($attributes[4]->getName())->toBe('PHPUnit\Framework\Attributes\CoversClass');
|
expect($attributes[4]->getName())->toBe('PHPUnit\Framework\Attributes\CoversClass');
|
||||||
@ -50,3 +54,18 @@ it('removes duplicated attributes', function () {
|
|||||||
->coversClass(TestCoversClass2::class, TestCoversClass1::class, Covers::class)
|
->coversClass(TestCoversClass2::class, TestCoversClass1::class, Covers::class)
|
||||||
->coversNothing()
|
->coversNothing()
|
||||||
->coversFunction('bar', 'foo', 'baz');
|
->coversFunction('bar', 'foo', 'baz');
|
||||||
|
|
||||||
|
it('guesses if the given argument is a class or function', function () {
|
||||||
|
$attributes = (new ReflectionClass($this))->getAttributes();
|
||||||
|
|
||||||
|
expect($attributes[7]->getName())->toBe('PHPUnit\Framework\Attributes\CoversClass');
|
||||||
|
expect($attributes[7]->getArguments()[0])->toBe('P\Tests\Features\TestCoversClass3');
|
||||||
|
expect($attributes[8]->getName())->toBe('PHPUnit\Framework\Attributes\CoversFunction');
|
||||||
|
expect($attributes[8]->getArguments()[0])->toBe('testCoversFunction');
|
||||||
|
})->covers(TestCoversClass3::class, 'testCoversFunction');
|
||||||
|
|
||||||
|
it('throws exception if no class nor method has been found', function () {
|
||||||
|
$testCall = new TestCall(TestSuite::getInstance(), 'filename', 'description', fn () => 'closure');
|
||||||
|
|
||||||
|
$testCall->covers('fakeName');
|
||||||
|
})->throws(InvalidArgumentException::class, 'No class or method named "fakeName" has been found.');
|
||||||
|
|||||||
Reference in New Issue
Block a user