From 109a93d6b10d5b3e8012ead318fdcce1e74ba19c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Belin?= Date: Sat, 24 Nov 2018 23:03:07 +0100 Subject: [PATCH] Code optimization --- lib/models/Team.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/models/Team.php b/lib/models/Team.php index d28e593..09eda04 100644 --- a/lib/models/Team.php +++ b/lib/models/Team.php @@ -54,7 +54,7 @@ class Team implements \JsonSerializable { static function fromJson(object $map): self { return (new static(isset($map->id) && is_int($map->id) ? $map->id : -1, isset($map->name) && is_string($map->name) ? $map->name : '')) ->setDescription(isset($map->description) && is_string($map->description) ? $map->description : '') - ->setPermission(isset($map->permission) && is_string($map->permission) ? $map->permission : TeamPermission::NONE); + ->setPermission($map->permission ?? TeamPermission::NONE); } /** @@ -128,7 +128,7 @@ class Team implements \JsonSerializable { * @return $this This instance. */ function setPermission(string $value): self { - $this->permission = TeamPermission::isDefined($value) ? $value : TeamPermission::NONE; + $this->permission = TeamPermission::coerce($value, TeamPermission::NONE); return $this; } }